| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20241217192535.4892fb1a@kernel.org>
Date: Tue, 17 Dec 2024 19:25:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Divya Koppera <divya.koppera@...rochip.com>
Cc: <andrew@...n.ch>, <arun.ramadoss@...rochip.com>,
<UNGLinuxDriver@...rochip.com>, <hkallweit1@...il.com>,
<linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
<pabeni@...hat.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <richardcochran@...il.com>,
<vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds
ptp library for Microchip phys
On Fri, 13 Dec 2024 17:44:00 +0530 Divya Koppera wrote:
> + rc = phy_write_mmd(phydev, PTP_MMD(clock),
> + MCHP_RDS_PTP_TX_PARSE_CONFIG(BASE_PORT(clock)),
> + txcfg);
You should probably wrap phy_{read,write}_mmd() into small helpers
which do the BASE_PORT() thing, and PTP_MMD() thing.
Just pass the offset (like MCHP_RDS_PTP_TX_PARSE_CONFIG).
Powered by blists - more mailing lists