linux-kernel - RE: [EXTERNAL] [PATCH net v2 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CH0PR18MB4339046C2D3690FB297B093DCD052@CH0PR18MB4339.namprd18.prod.outlook.com>
Date: Wed, 18 Dec 2024 06:03:14 +0000
From: Geethasowjanya Akula <gakula@...vell.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Bharat Bhushan
	<bbhushan2@...vell.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S.
 Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "error27@...il.com" <error27@...il.com>,
        Przemek Kitszel
	<przemyslaw.kitszel@...el.com>
Subject: RE: [EXTERNAL] [PATCH net v2 1/2] octeontx2-pf: fix netdev memory
 leak in rvu_rep_create()



>-----Original Message-----
>From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
>Sent: Tuesday, December 17, 2024 10:53 AM
>To: Sunil Kovvuri Goutham <sgoutham@...vell.com>; Geethasowjanya Akula
><gakula@...vell.com>; Subbaraya Sundeep Bhatta <sbhatta@...vell.com>;
>Hariprasad Kelam <hkelam@...vell.com>; Bharat Bhushan
><bbhushan2@...vell.com>; Andrew Lunn <andrew+netdev@...n.ch>; David
>S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
>Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Simon
>Horman <horms@...nel.org>; netdev@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Cc: dan.carpenter@...aro.org; kernel-janitors@...r.kernel.org;
>error27@...il.com; harshit.m.mogalapalli@...cle.com; Przemek Kitszel
><przemyslaw.kitszel@...el.com>
>Subject: [EXTERNAL] [PATCH net v2 1/2] octeontx2-pf: fix netdev memory leak
>in rvu_rep_create()
>
>When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this
>incomplete iteration before going to "exit:" label.
>
>Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
>---
>v1-->v2: Change the Fixes tag to the correct one as pointed out by
>v1-->Przemek
>---
> drivers/net/ethernet/marvell/octeontx2/nic/rep.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
>index 232b10740c13..9e3fcbae5dee 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
>@@ -680,8 +680,10 @@ int rvu_rep_create(struct otx2_nic *priv, struct
>netlink_ext_ack *extack)
> 		ndev->features |= ndev->hw_features;
> 		eth_hw_addr_random(ndev);
> 		err = rvu_rep_devlink_port_register(rep);
>-		if (err)
>+		if (err) {
>+			free_netdev(ndev);
> 			goto exit;
>+		}
>
> 		SET_NETDEV_DEVLINK_PORT(ndev, &rep->dl_port);
> 		err = register_netdev(ndev);
>--
>2.46.0
Ack. Thanks for the fix.