[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4717dbb3-4fea-4ca0-800e-07ceed4dfec0@kernel.org>
Date: Wed, 18 Dec 2024 09:11:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kevin Chen <kevin_chen@...eedtech.com>, "robh@...nel.org"
<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "joel@....id.au"
<joel@....id.au>, "andrew@...econstruct.com.au"
<andrew@...econstruct.com.au>, "tglx@...utronix.de" <tglx@...utronix.de>,
"catalin.marinas@....com" <catalin.marinas@....com>,
"will@...nel.org" <will@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
"olof@...om.net" <olof@...om.net>,
"quic_bjorande@...cinc.com" <quic_bjorande@...cinc.com>,
"geert+renesas@...der.be" <geert+renesas@...der.be>,
"dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>,
"konradybcio@...nel.org" <konradybcio@...nel.org>,
"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
"johan+linaro@...nel.org" <johan+linaro@...nel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"soc@...ts.linux.dev" <soc@...ts.linux.dev>
Subject: Re: [PATCH v3 2/6] dt-bindings: arm: aspeed: Add ASPEED AST27XX SoC
On 18/12/2024 03:55, Kevin Chen wrote:
> Hi Krzk,
>
>>> On 12/12/2024 16:52, Kevin Chen wrote:
>>>> Signed-off-by: Kevin Chen <kevin_chen@...eedtech.com>
>>>> ---
>>>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 6 ++++++
>>>> 1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>>> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>>> index 2f92b8ab08fa..20191fee1f5b 100644
>>>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>>> @@ -101,4 +101,10 @@ properties:
>>>> - ufispace,ncplite-bmc
>>>> - const: aspeed,ast2600
>>>>
>>>> + - description: AST2700 based boards
>>>> + items:
>>>> + - enum:
>>>> + - aspeed,ast2700-evb
>>>> + - const: aspeed,ast2700
>>>> +
>>>> additionalProperties: true
>>>
>>>
>>>
>>> This patchset is just corrupted. You already sent it as patch #1.
>>>
>>> Please run scripts/checkpatch.pl and fix reported warnings. Then
>>> please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
>>> Some warnings can be ignored, especially from --strict run, but the
>>> code here looks like it needs a fix. Feel free to get in touch if the
>>> warning is not clear.
>> BTW, you already got here same comments before and this is third time you
>> send exactly the same without implementing what we asked you.
> Please check the following message.
> https://lore.kernel.org/lkml/PSAPR06MB494943F3F34881D23CEEBD9A897D2@PSAPR06MB4949.apcprd06.prod.outlook.com/
>
> Or, how do you think what is better for me to add ast2700-evb?
Please stop responding just to make me go away.
Read the comments from half a year ago, which you have never implemented:
https://lore.kernel.org/lkml/e6cb6f26-fef2-49bc-ab25-fdc9a659f593@kernel.org/
On every new patch I was asking you to go back, but again you were
ignoring each of such messages.
Best regards,
Krzysztof
Powered by blists - more mailing lists