linux-kernel - Re: [PATCH RESEND V2 net 2/7] net: hns3: fix missing features due to dev->features configuration too early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2KS3IClps8eV3c/@mev-dev.igk.intel.com>
Date: Wed, 18 Dec 2024 10:16:12 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Jijie Shao <shaojijie@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shenjian15@...wei.com, wangpeiyang1@...wei.com,
	liuyonglong@...wei.com, chenhao418@...wei.com,
	jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND V2 net 2/7] net: hns3: fix missing features due to
 dev->features configuration too early

On Tue, Dec 17, 2024 at 09:08:34AM +0800, Jijie Shao wrote:
> From: Hao Lan <lanhao@...wei.com>
> 
> Currently, the netdev->features is configured in hns3_nic_set_features.
> As a result, __netdev_update_features considers that there is no feature
> difference, and the procedures of the real features are missing.
> 
> Fixes: 2a7556bb2b73 ("net: hns3: implement ndo_features_check ops for hns3 driver")
> Signed-off-by: Hao Lan <lanhao@...wei.com>
> Signed-off-by: Jian Shen <shenjian15@...wei.com>
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> index 43377a7b2426..a7e3b22f641c 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
> @@ -2452,7 +2452,6 @@ static int hns3_nic_set_features(struct net_device *netdev,
>  			return ret;
>  	}
>  
> -	netdev->features = features;
>  	return 0;

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

Thanks

>  }
>  
> -- 
> 2.33.0