linux-kernel - Re: [PATCH] x86/static-call: fix 32-bit build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218094705.GD2484@noisy.programming.kicks-ass.net>
Date: Wed, 18 Dec 2024 10:47:05 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Juergen Gross <jgross@...e.com>
Cc: linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Jason Baron <jbaron@...mai.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ard Biesheuvel <ardb@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] x86/static-call: fix 32-bit build

On Wed, Dec 18, 2024 at 09:02:28AM +0100, Juergen Gross wrote:
> In 32-bit x86 builds CONFIG_STATIC_CALL_INLINE isn't set, leading to
> static_call_initialized not being available.
> 
> Define it as "0" in that case.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: 0ef8047b737d ("x86/static-call: provide a way to do very early static-call updates")
> Signed-off-by: Juergen Gross <jgross@...e.com>

Works for me -- I seem to have missed those patches landing, and I'm
assuming this patch is going to go along with them others that introduce
the problem.

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>

> ---
>  include/linux/static_call.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/static_call.h b/include/linux/static_call.h
> index 785980af8972..78a77a4ae0ea 100644
> --- a/include/linux/static_call.h
> +++ b/include/linux/static_call.h
> @@ -138,7 +138,6 @@
>  #ifdef CONFIG_HAVE_STATIC_CALL
>  #include <asm/static_call.h>
>  
> -extern int static_call_initialized;
>  /*
>   * Either @site or @tramp can be NULL.
>   */
> @@ -161,6 +160,8 @@ extern void arch_static_call_transform(void *site, void *tramp, void *func, bool
>  
>  #ifdef CONFIG_HAVE_STATIC_CALL_INLINE
>  
> +extern int static_call_initialized;
> +
>  extern int __init static_call_init(void);
>  
>  extern void static_call_force_reinit(void);
> @@ -226,6 +227,8 @@ extern long __static_call_return0(void);
>  
>  #elif defined(CONFIG_HAVE_STATIC_CALL)
>  
> +#define static_call_initialized 0
> +
>  static inline int static_call_init(void) { return 0; }
>  
>  #define DEFINE_STATIC_CALL(name, _func)					\
> @@ -282,6 +285,8 @@ extern long __static_call_return0(void);
>  
>  #else /* Generic implementation */
>  
> +#define static_call_initialized 0
> +
>  static inline int static_call_init(void) { return 0; }
>  
>  static inline long __static_call_return0(void)
> -- 
> 2.43.0
> 
>