linux-kernel - Re: [ovs-dev] [PATCH net] selftests: openvswitch: fix tcpdump execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6D309AF5-AC5A-4F68-9F86-84E66AC0FB4F@redhat.com>
Date: Wed, 18 Dec 2024 11:08:29 +0100
From: Eelco Chaudron <echaudro@...hat.com>
To: Adrian Moreno <amorenoz@...hat.com>
Cc: linux-kselftest@...r.kernel.org, dev@...nvswitch.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Shuah Khan <shuah@...nel.org>, "David S. Miller" <davem@...emloft.net>
Subject: Re: [ovs-dev] [PATCH net] selftests: openvswitch: fix tcpdump
 execution

On 17 Dec 2024, at 22:16, Adrian Moreno wrote:

> Fix the way tcpdump is executed by:
> - Using the right variable for the namespace. Currently the use of the
>   empty "ns" makes the command fail.
> - Waiting until it starts to capture to ensure the interesting traffic
>   is caught on slow systems.
> - Using line-buffered output to ensure logs are available when the test
>   is paused with "-p". Otherwise the last chunk of data might only be
>   written when tcpdump is killed.
>
> Fixes: 74cc26f416b9 ("selftests: openvswitch: add interface support")
> Signed-off-by: Adrian Moreno <amorenoz@...hat.com>

Thank for fixing this, the change looks good to me.

Acked-by: Eelco Chaudron <echaudro@...hat.com>