linux-kernel - Re: [PATCH RESEND] drm/bridge: ti-sn65dsi83: use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5160e46-7f72-4a3b-ad31-f26c33d5f22a@linaro.org>
Date: Wed, 18 Dec 2024 11:14:42 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Herve Codina <herve.codina@...tlin.com>,
 Simona Vetter <simona.vetter@...ll.ch>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 Louis Chauvet <louis.chauvet@...tlin.com>,
 Andi Shyti <andi.shyti@...ux.intel.com>
Subject: Re: [PATCH RESEND] drm/bridge: ti-sn65dsi83: use dev_err_probe when
 failing to get panel bridge

Hi,

On 17/12/2024 17:06, Luca Ceresoli wrote:
> Hello,
> 
> On Tue, 17 Dec 2024 17:02:51 +0100
> Luca Ceresoli <luca.ceresoli@...tlin.com> wrote:
> 
>> When devm_drm_of_get_bridge() fails, the probe fails silently. Use
>> dev_err_probe() instead to log an error or report the deferral reason,
>> whichever is applicable.
>>
>> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> 
> This patch got a reviewed-by from Andi Shyti when I sent it the first
> time [0], but b4 didn't keep it when resending. I think it is fair for
> me to add it now, even though I'm not sure patchwork and b4 will catch
> it:
> 
> Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com>
> 
> [0] https://lore.kernel.org/all/ZrtuksiarZNS8L79@ashyti-mobl2.lan/
> 

Added it manually!

Thanks
Neil