linux-kernel - Re: [PATCH 1/1] events/core: fix error run/enable ratio display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218104255.GE2484@noisy.programming.kicks-ass.net>
Date: Wed, 18 Dec 2024 11:42:55 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Yeoreum Yun <yeoreum.yun@....com>
Cc: mingo@...hat.com, acme@...nel.org, amhyung@...nel.org,
	mark.rutland@....com, alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, james.clark@...aro.org,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	nd@....com
Subject: Re: [PATCH 1/1] events/core: fix error run/enable ratio display


git log --oneline kernel/events/core.c 

Compare result with your subject.

On Wed, Dec 18, 2024 at 08:46:56AM +0000, Yeoreum Yun wrote:
> when runs below command (with core pmu) sometime perf prints error
> ratio for each perf.
> 
> sudo ./perf stat -vvv -e armv8_pmuv3_0/event=0x08/ -e armv8_pmuv3_1/event=0x08/ -- stress-ng --pthread=2 -t 2s
> ...
> armv8_pmuv3_0/event=0x08/: -1: 1081702126 2289429840 2174835740
> armv8_pmuv3_1/event=0x08/: -1: 794080238 1950025700 847648440
> armv8_pmuv3_0/event=0x08/: 1138698008 2289429840 2174835740
> armv8_pmuv3_1/event=0x08/: 1826791390 1950025700 847648440
> 
>  Performance counter stats for 'stress-ng --pthread=2 -t 2s':
> 
>      1,138,698,008      armv8_pmuv3_0/event=0x08/                                               (94.99%)
>      1,826,791,390      armv8_pmuv3_1/event=0x08/                                               (43.47%)

At this point I've no idea what the error is. You start by saying there
is an error, but then give no clue.

> This happens because of missing total_enable_time of inactivate event.
> it's enabled time doesn't update at the event_sched_out() because state
> isn't PERF_EVENT_STATE_ACTIVE but PERF_EVENT_STATE_INACTIVE.

time tracking doesn't happen at sched calls -- you'll find a grand total
of 0 perf_event_update_time() calls in them.

Also, things like group_sched_out() don't even call into
event_sched_out() when !ACTIVE.

So why is event_sched_out() the right place to change here?

Also, I've still no clue under what condition all this is supposed to
have happened :/

> For example, Suppose there're two events:
>     e0: with pmu0 which supports only cpu0
>     e1: with pmu1 which supports only cpu1.
> then
> 
>                CPU0                  CPU1                     CPU0
>           |  in | out |       | in | out     |       | in      | out (exit)   |
> ------------------------------------------------------------------------------
> ctx->time |  0  | t1  |       | t1 | t1 + t2 |       | t1 + t2 | t1 + t2 + t3 |
> ------------------------------------------------------------------------------
> e0->ena   |  0  | t1  |       | t1 | t1      |       | t1 + t2 | t1 + t2 + t3 |
> ------------------------------------------------------------------------------
> e0->run   |  0  | t1  |       | t1 | t1 + t2 |       | t1 + t2 | t1 + t3      |
> ------------------------------------------------------------------------------
> e1->ena   |  0  | 0   |       | t1 | t1 + t2 |       | t1 + t2 | t1 + t2      |
> ------------------------------------------------------------------------------
> e1->run   |  0  | 0   |       | 0  | t2      |       | t1 + t2 | t2           |
> ------------------------------------------------------------------------------
> 
> at the CPU0, state of e1 is PERF_EVENT_STATE_INACTIVE since it doesn't
> support on CPU0. So when event_sched_out() it failed to update its
> total_enable_time and it makes error print of run/ena ratio.

Sorry, I have no idea what you're saying. I can't relate the table to
the text in any meaningful way.