linux-kernel - RE: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CO1PR11MB4771ED94C34E6A15F87AD812E2052@CO1PR11MB4771.namprd11.prod.outlook.com>
Date: Wed, 18 Dec 2024 10:52:56 +0000
From: <Divya.Koppera@...rochip.com>
To: <kuba@...nel.org>, <richardcochran@...il.com>
CC: <andrew@...n.ch>, <Arun.Ramadoss@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <vadim.fedorenko@...ux.dev>
Subject: RE: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds ptp
 library for Microchip phys

Hi Jakub,

Thanks for the review.

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, December 18, 2024 9:28 AM
> To: Richard Cochran <richardcochran@...il.com>
> Cc: Divya Koppera - I30481 <Divya.Koppera@...rochip.com>;
> andrew@...n.ch; Arun Ramadoss - I17769
> <Arun.Ramadoss@...rochip.com>; UNGLinuxDriver
> <UNGLinuxDriver@...rochip.com>; hkallweit1@...il.com;
> linux@...linux.org.uk; davem@...emloft.net; edumazet@...gle.com;
> pabeni@...hat.com; netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> vadim.fedorenko@...ux.dev
> Subject: Re: [PATCH net-next v7 2/5] net: phy: microchip_rds_ptp : Add rds
> ptp library for Microchip phys
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Tue, 17 Dec 2024 19:47:14 -0800 Richard Cochran wrote:
> > > > +static int mchp_rds_ptp_ts_info(struct mii_timestamper *mii_ts,
> > > > +                         struct kernel_ethtool_ts_info *info) {
> > > > +struct mchp_rds_ptp_clock *clock = container_of(mii_ts,
> > > > +                                               struct mchp_rds_ptp_clock,
> > > > +                                               mii_ts);
> > > > +
> > > > + info->phc_index =
> > > > +         clock->ptp_clock ? ptp_clock_index(clock->ptp_clock) :
> > > > + -1;
> > >
> > > under what condition can the clock be NULL?
> >
> > ptp_clock_register() can return PTR_ERR or null.
> 
> Fair point. Since this is a PTP library module, and an optional one (patch 1 has
> empty wrappers for its API) - can we make it depend on PTP being configured
> in?

Null check is not handled for ptp_clock_register. If that is done there, this is redundant.

Will fix this in next revision.

Thanks,
Divya