linux-kernel - Re: [PATCH] net: Convert proto_ops::getname to sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa6c671d-f4f4-446d-b024-923555c3f041@linux.ibm.com>
Date: Wed, 18 Dec 2024 13:26:37 +0100
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Kees Cook <kees@...nel.org>, Jakub Kicinski <kuba@...nel.org>
Cc: linux-kernel@...r.kernel.org,
        ", linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        ", netdev" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: Convert proto_ops::getname to sockaddr_storage


I had to shorten the CC-List to get this message through our mailserver, sorry about that.

On 17.12.24 03:34, Kees Cook wrote:
> diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
> index 7929df08d4e0..2612382e1a48 100644
> --- a/net/iucv/af_iucv.c
> +++ b/net/iucv/af_iucv.c
> @@ -848,14 +848,14 @@ static int iucv_sock_accept(struct socket *sock, struct socket *newsock,
>  	return err;
>  }
>  
> -static int iucv_sock_getname(struct socket *sock, struct sockaddr *addr,
> -			     int peer)
> +static int iucv_sock_getname(struct socket *sock,
> +			     struct sockaddr_storage *addr, int peer)
>  {
>  	DECLARE_SOCKADDR(struct sockaddr_iucv *, siucv, addr);
>  	struct sock *sk = sock->sk;
>  	struct iucv_sock *iucv = iucv_sk(sk);
>  
> -	addr->sa_family = AF_IUCV;
> +	siucv->sa_family = AF_IUCV;


This does not compile, it needs to be:
siucv->siucv_family = AF_IUCV;

>  
>  	if (peer) {
>  		memcpy(siucv->siucv_user_id, iucv->dst_user_id, 8);


With this change feel free to add my 
Acked-by: Alexandra Winter <wintera@...ux.ibm.com>