linux-kernel - Re: [PATCH 1/2] m68k: coldfire: Use proper clock rate for timers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbb9070e-5756-4208-8a46-b26d2dfce3c3@linux-m68k.org>
Date: Wed, 18 Dec 2024 22:36:08 +1000
From: Greg Ungerer <gerg@...ux-m68k.org>
To: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>,
 Geert Uytterhoeven <geert@...ux-m68k.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Thomas Gleixner <tglx@...utronix.de>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
 linux-m68k@...r.kernel.org
Subject: Re: [PATCH 1/2] m68k: coldfire: Use proper clock rate for timers

Hi JM,

On 2/12/24 19:29, Jean-Michel Hautbois wrote:
> The DMA and PIT timers are clocked at fsys/2. Fix it.
> While at it, fix the comment naming for DMA timers (duplicated tmr.2).

This looks like a stand alone fix in its own right, so I have pushed
this into the m68knommu git tree, for-next branch.

Thanks
Greg



> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>
> ---
>   arch/m68k/coldfire/m5441x.c | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> index 405e9d5c832c0d41978615a646de21f2fce61afb..7a25cfc7ac07570ff15da3c55d080a717cf93a06 100644
> --- a/arch/m68k/coldfire/m5441x.c
> +++ b/arch/m68k/coldfire/m5441x.c
> @@ -33,14 +33,14 @@ DEFINE_CLK(0, "mcfuart.0", 24, MCF_BUSCLK);
>   DEFINE_CLK(0, "mcfuart.1", 25, MCF_BUSCLK);
>   DEFINE_CLK(0, "mcfuart.2", 26, MCF_BUSCLK);
>   DEFINE_CLK(0, "mcfuart.3", 27, MCF_BUSCLK);
> -DEFINE_CLK(0, "mcftmr.0", 28, MCF_CLK);
> -DEFINE_CLK(0, "mcftmr.1", 29, MCF_CLK);
> -DEFINE_CLK(0, "mcftmr.2", 30, MCF_CLK);
> -DEFINE_CLK(0, "mcftmr.3", 31, MCF_CLK);
> -DEFINE_CLK(0, "mcfpit.0", 32, MCF_CLK);
> -DEFINE_CLK(0, "mcfpit.1", 33, MCF_CLK);
> -DEFINE_CLK(0, "mcfpit.2", 34, MCF_CLK);
> -DEFINE_CLK(0, "mcfpit.3", 35, MCF_CLK);
> +DEFINE_CLK(0, "mcftmr.0", 28, MCF_BUSCLK);
> +DEFINE_CLK(0, "mcftmr.1", 29, MCF_BUSCLK);
> +DEFINE_CLK(0, "mcftmr.2", 30, MCF_BUSCLK);
> +DEFINE_CLK(0, "mcftmr.3", 31, MCF_BUSCLK);
> +DEFINE_CLK(0, "mcfpit.0", 32, MCF_BUSCLK);
> +DEFINE_CLK(0, "mcfpit.1", 33, MCF_BUSCLK);
> +DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
> +DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
>   DEFINE_CLK(0, "mcfeport.0", 37, MCF_CLK);
>   DEFINE_CLK(0, "mcfadc.0", 38, MCF_CLK);
>   DEFINE_CLK(0, "mcfdac.0", 39, MCF_CLK);
> @@ -167,8 +167,8 @@ static struct clk * const disable_clks[] __initconst = {
>   	&__clk_0_14, /* i2c.1 */
>   	&__clk_0_22, /* i2c.0 */
>   	&__clk_0_23, /* dspi.0 */
> -	&__clk_0_28, /* tmr.1 */
> -	&__clk_0_29, /* tmr.2 */
> +	&__clk_0_28, /* tmr.0 */
> +	&__clk_0_29, /* tmr.1 */
>   	&__clk_0_30, /* tmr.2 */
>   	&__clk_0_31, /* tmr.3 */
>   	&__clk_0_32, /* pit.0 */
>