linux-kernel - Re: [PATCH] doc: power: Add missing parameter description for memory_bm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hQfGdsjy-VQmw4HV5Bqcv7mvR_bLnabGKb7E-obJb2Zw@mail.gmail.com>
Date: Wed, 18 Dec 2024 14:57:57 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Prabhav Kumar Vaish <pvkumar5749404@...il.com>
Cc: rafael@...nel.org, pavel@....cz, len.brown@...el.com, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] doc: power: Add missing parameter description for memory_bm_create

On Thu, Dec 12, 2024 at 5:16 PM Prabhav Kumar Vaish
<pvkumar5749404@...il.com> wrote:
>
> Added the parameter description for bm, gfp_mask and safe_needed
> for the function memory_bm_create
>
> Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@...il.com>
> ---
>  kernel/power/snapshot.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 30894d8f0a78..690dd1f467b9 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -680,6 +680,9 @@ static int create_mem_extents(struct list_head *list, gfp_t gfp_mask)
>
>  /**
>   * memory_bm_create - Allocate memory for a memory bitmap.
> + * @bm: Memory bitmap.
> + * @gfp_mask: GFP mask for the allocation.
> + * @safe_needed: Get pages not used before hibernation (restore only)

This isn't exactly accurate and I'd rather drop the comment entirely.

>   */
>  static int memory_bm_create(struct memory_bitmap *bm, gfp_t gfp_mask,
>                             int safe_needed)
> --
> 2.34.1
>