linux-kernel - Re: [PATCH v7 8/8] PCI/AER: Add prefixes to printouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f5e8d07-d459-7a8e-844e-6f1b432763fe@linux.intel.com>
Date: Wed, 18 Dec 2024 16:15:34 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Yazen Ghannam <yazen.ghannam@....com>
cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org, 
    Krzysztof Wilczyński <kw@...ux.com>, 
    Lukas Wunner <lukas@...ner.de>, 
    Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
    Mahesh J Salgaonkar <mahesh@...ux.ibm.com>, 
    Oliver O'Halloran <oohall@...il.com>, linuxppc-dev@...ts.ozlabs.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 8/8] PCI/AER: Add prefixes to printouts

On Tue, 17 Dec 2024, Yazen Ghannam wrote:

> On Tue, Dec 17, 2024 at 03:53:58PM +0200, Ilpo Järvinen wrote:
> > Only part of the AER diagnostic printouts use "AER:" prefix because
> > they use low-level pci_printk() directly to allow selecting level.
> > 
> > Add "AER:" prefix to lines that are printed with pci_printk().
> 
> Can we please include the "HW_ERR" prefix also? IMO, it would make the
> kernel messages more consistent if all hardware error info had it.

While I'm not against your suggestion, it doesn't belong into this patch 
as there are other lines beyond those touched in this patch that would 
need to have HW_ERR as well.

I think I'll just drop this patch from this series and move it into the 
pci_printk() series to avoid the inter-series conflict. Adding the HW_ERR 
change would conflict badly with Karolina Stolarek's series so I'm not 
sure if I want to pursue that change at this point (it's only my todo 
list so it won't get forgotten).

-- 
 i.