linux-kernel - Re: [PATCH] [v2] accel/amdxdna: include linux/slab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a3d1829-8d63-4f69-b34f-d5667bcf4826@amd.com>
Date: Wed, 18 Dec 2024 08:30:08 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Arnd Bergmann <arnd@...nel.org>, Min Ma <min.ma@....com>,
 Lizhi Hou <lizhi.hou@....com>, Oded Gabbay <ogabbay@...nel.org>,
 Jeffrey Hugo <quic_jhugo@...cinc.com>
Cc: Arnd Bergmann <arnd@...db.de>,
 Narendra Gutta <VenkataNarendraKumar.Gutta@....com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] accel/amdxdna: include linux/slab.h

On 12/18/2024 02:58, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This driver fails to build in random configurations:
> 
> drivers/accel/amdxdna/aie2_solver.c: In function 'remove_partition_node':
> drivers/accel/amdxdna/aie2_solver.c:121:9: error: implicit declaration of function 'kfree' [-Wimplicit-function-declaration]
>    121 |         kfree(pt_node);
>        |         ^~~~~
> drivers/accel/amdxdna/aie2_solver.c: In function 'get_free_partition':
> drivers/accel/amdxdna/aie2_solver.c:153:19: error: implicit declaration of function 'kzalloc' [-Wimplicit-function-declaration]
>    153 |         pt_node = kzalloc(sizeof(*pt_node), GFP_KERNEL);
> 
> Add the missing include.
> 
> Fixes: c88d3325ae69 ("accel/amdxdna: Add hardware resource solver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> This one is still needed, I had previously combined two missing includes
> in one patch

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

Applied to drm-misc-next.

221e29e197981 accel/amdxdna: include linux/slab.h

> ---
>   drivers/accel/amdxdna/aie2_solver.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/accel/amdxdna/aie2_solver.c b/drivers/accel/amdxdna/aie2_solver.c
> index 1939625d6027..2013d1f13aae 100644
> --- a/drivers/accel/amdxdna/aie2_solver.c
> +++ b/drivers/accel/amdxdna/aie2_solver.c
> @@ -8,6 +8,7 @@
>   #include <drm/drm_print.h>
>   #include <linux/bitops.h>
>   #include <linux/bitmap.h>
> +#include <linux/slab.h>
>   
>   #include "aie2_solver.h"
>