linux-kernel - Re: [PATCH 00/10] Account page tables at all levels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7398426-56d1-40b4-a1c9-40ae8c8a4b4b@intel.com>
Date: Thu, 19 Dec 2024 09:13:57 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Kevin Brodsky <kevin.brodsky@....com>, linux-mm@...ck.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Catalin Marinas <catalin.marinas@....com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Linus Walleij <linus.walleij@...aro.org>, Andy Lutomirski <luto@...nel.org>,
 Peter Zijlstra <peterz@...radead.org>, "Mike Rapoport (IBM)"
 <rppt@...nel.org>, Ryan Roberts <ryan.roberts@....com>,
 Thomas Gleixner <tglx@...utronix.de>, Will Deacon <will@...nel.org>,
 Matthew Wilcox <willy@...radead.org>, linux-alpha@...r.kernel.org,
 linux-arch@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
 linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org,
 linux-parisc@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
 linux-um@...ts.infradead.org, loongarch@...ts.linux.dev, x86@...nel.org
Subject: Re: [PATCH 00/10] Account page tables at all levels

On 12/19/24 08:44, Kevin Brodsky wrote:
>   +---------------+-------------------------+-----------------------+--------------+------------------------------------+
>   | x86           | Y                       | Y                     | Y/N          | kmem_cache at pgd level if PAE     |
>   +---------------+-------------------------+-----------------------+--------------+------------------------------------+

This is a really rare series that adds functionality _and_ removes code
overall. It looks really good to me. The x86 implementation seems to be
captured just fine in the generic one:

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>

One super tiny nit is that the PAE pgd _can_ be allocated using
__get_free_pages(). It was originally there for Xen, but I think it's
being used for PTI only at this point and the comments are wrong-ish.

I kinda think we should just get rid of the 32-bit kmem_cache entirely.