linux-kernel - Re: [PATCH 09/10] arm64: dts: imx8mp-skov: fix phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab896c6a-49a2-4eda-bee3-c429fe8cef1b@pengutronix.de>
Date: Thu, 19 Dec 2024 18:49:12 +0100
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Oleksij Rempel
 <o.rempel@...gutronix.de>, devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/10] arm64: dts: imx8mp-skov: fix phy-mode

On 19.12.24 18:45, Frank Li wrote:
> On Thu, Dec 19, 2024 at 08:25:33AM +0100, Ahmad Fatoum wrote:
>> From: Oleksij Rempel <o.rempel@...gutronix.de>
>>
>> Use rgmii-rxid instead of rgmii-txid. It should have no effect here,
>> but rxid is the correct value in our case.
> 
> Use rgmii-rxid instead of rgmii-txid because ...

I consider it useful information to note that it should introduce no
functional change.

Thanks,
Ahmad

> 
> Frank
> 
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
>> index 80d212acc0c3..a683f46fcbab 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi
>> @@ -215,7 +215,7 @@ adc: adc@0 {
>>  &eqos {
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&pinctrl_eqos>;
>> -	phy-mode = "rgmii-txid";
>> +	phy-mode = "rgmii-rxid";
>>  	status = "okay";
>>
>>  	fixed-link {
>>
>> --
>> 2.39.5
>>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |