linux-kernel - Re: [PATCH 1/3] dt-bindings: Add ROHM BD79703

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241219-acts-glare-2bc1e723ab20@spud>
Date: Thu, 19 Dec 2024 18:59:53 +0000
From: Conor Dooley <conor@...nel.org>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: Add ROHM BD79703

On Thu, Dec 19, 2024 at 01:39:11PM +0200, Matti Vaittinen wrote:
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        dac@0 {

nit: should be a blank line before the child node.
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

> +            compatible = "rohm,bd79703";
> +            reg = <0>;
> +            spi-max-frequency = <30000000>;
> +            vcc-supply = <&vcc>;
> +            vfs-supply = <&vref>;
> +        };
> +    };
> +...
> -- 
> 2.47.0
> 



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)