[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZ5v0hE6-QDOE7PcCAfSU78mjmQqo2mjXf+nBeaZ8eD6rffzg@mail.gmail.com>
Date: Thu, 19 Dec 2024 21:01:19 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Robert Moore <robert.moore@...el.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
linux-usb@...r.kernel.org, acpica-devel@...ts.linux.dev,
Sakari Ailus <sakari.ailus@...ux.intel.com>, Dan Carpenter <dan.carpenter@...aro.org>,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH v5 0/7] ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI)
On Mon, Dec 16, 2024 at 10:17 PM Ricardo Ribalda <ribalda@...omium.org> wrote:
>
> We want to be able to compile_test the ipu6 driver in situations with
> !ACPI.
>
> In order to do this we had to add some conditional #ifs, which lead to
> false positives on the static analysers.
>
> Let's implement some helpers when !ACPI in the acpi headers to make the
> code more easier to maintain.
>
> To: Rafael J. Wysocki <rafael@...nel.org>
> To: Len Brown <lenb@...nel.org>
> To: Robert Moore <robert.moore@...el.com>
> To: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Cc: Dan Carpenter <dan.carpenter@...aro.org>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-acpi@...r.kernel.org
> Cc: acpica-devel@...ts.linux.dev
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
>
> Changes in v5:
> - Remove Fixes tag
> - redefine acpi_get_physical_device_location() to return bool
> - Link to v4: https://lore.kernel.org/r/20241211-fix-ipu-v4-0-4102e97aceb6@chromium.org
>
> Changes in v4 (Thanks Sakari & Mauro):
> - Squash the two ipu changes and merge everything via ACPI
> - Space after ;
> - move acpi_device_handle to avoid fwd declaration.
> - Link to v3: https://lore.kernel.org/r/20241210-fix-ipu-v3-0-00e409c84a6c@chromium.org
>
> Changes in v3:
> - Prefer static inlines to macros (Thanks Rafael).
> - Link to v2: https://lore.kernel.org/r/20241122-fix-ipu-v2-0-bba65856e9ff@chromium.org
>
> Changes in v2:
> - Add helpers in acpi to avoid conditional compilation
> - Link to v1: https://lore.kernel.org/r/20241122-fix-ipu-v1-1-246e254cb77c@chromium.org
>
> ---
> Ricardo Ribalda (7):
> ACPI: bus: change the prototype for acpi_get_physical_device_location
> ACPI: bus: implement for_each_acpi_dev_match when !ACPI
> ACPI: bus: implement acpi_get_physical_device_location when !ACPI
> ACPI: header: implement acpi_device_handle when !ACPI
> ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI
> ACPI: bus: implement acpi_device_hid when !ACPI
> media: ipu-bridge: Remove unneeded conditional compilations
>
> drivers/acpi/mipi-disco-img.c | 3 +--
> drivers/acpi/scan.c | 4 +---
> drivers/acpi/utils.c | 7 +++----
> drivers/base/physical_location.c | 4 +---
> drivers/media/pci/intel/ipu-bridge.c | 29 ++++-------------------------
> drivers/usb/core/usb-acpi.c | 3 +--
> include/acpi/acpi_bus.h | 23 ++++++++++++++++++++---
> include/linux/acpi.h | 5 +++++
> 8 files changed, 36 insertions(+), 42 deletions(-)
> ---
Series applied as 6.14 material, thanks!
Powered by blists - more mailing lists