linux-kernel - Re: [PATCH 1/3] nfsd: add more info to WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN-5tyFHmBUWR5d=Rt08MxQobtmZatLw7umeRV=8BN_GUs-vxg@mail.gmail.com>
Date: Thu, 19 Dec 2024 16:42:46 -0500
From: Olga Kornievskaia <aglo@...ch.edu>
To: Jeff Layton <jlayton@...nel.org>
Cc: Chuck Lever <chuck.lever@...cle.com>, Neil Brown <neilb@...e.de>, 
	Olga Kornievskaia <kolga@...app.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, 
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] nfsd: add more info to WARN_ON_ONCE on failed callbacks

On Thu, Dec 19, 2024 at 4:33 PM Jeff Layton <jlayton@...nel.org> wrote:
>
> On Thu, 2024-12-19 at 16:23 -0500, Olga Kornievskaia wrote:
> > On Mon, Aug 26, 2024 at 8:54 AM Jeff Layton <jlayton@...nel.org> wrote:
> > >
> > > Currently, you get the warning and stack trace, but nothing is printed
> > > about the relevant error codes. Add that in.
> > >
> > > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > > ---
> > >  fs/nfsd/nfs4callback.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> > > index d756f443fc44..dee9477cc5b5 100644
> > > --- a/fs/nfsd/nfs4callback.c
> > > +++ b/fs/nfsd/nfs4callback.c
> > > @@ -1333,7 +1333,8 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
> > >                 return;
> > >
> > >         if (cb->cb_status) {
> > > -               WARN_ON_ONCE(task->tk_status);
> > > +               WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",
> > > +                         cb->cb_status, task->tk_status);
> >
> > Can we add cb->cb_ops->opcode to that as well?
>
> I'd be fine with that, but this patch is already merged. Care to
> propose one that could go on top?

Yep of course was just testing if that was Ok. I just realized it
would have saved a lot of time (me coming up with that fix I just
posted) if I knew what callback was in play.

>
> >
> > >                 task->tk_status = cb->cb_status;
> > >         }
> > >
> > >
> > > --
> > > 2.46.0
> > >
> > >
>
> --
> Jeff Layton <jlayton@...nel.org>