linux-kernel - drivers/hid/hid-logitech-hidpp.c:156: warning: Excess struct member 'dev' description in 'hidpp_scroll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202412200537.jBsOPSSY-lkp@intel.com>
Date: Fri, 20 Dec 2024 05:53:39 +0800
From: kernel test robot <lkp@...el.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: drivers/hid/hid-logitech-hidpp.c:156: warning: Excess struct member
 'dev' description in 'hidpp_scroll_counter'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8faabc041a001140564f718dabe37753e88b37fa
commit: 0610430e3dea51c9a00565af685745898048fa2b HID: logitech-hidpp: add input_device ptr to struct hidpp_device
date:   6 years ago
config: arm-randconfig-001-20241212 (https://download.01.org/0day-ci/archive/20241220/202412200537.jBsOPSSY-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241220/202412200537.jBsOPSSY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412200537.jBsOPSSY-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hid/hid-logitech-hidpp.c:156: warning: Excess struct member 'dev' description in 'hidpp_scroll_counter'
   drivers/hid/hid-logitech-hidpp.c:242: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * hidpp_send_message_sync() returns 0 in case of success, and something else
   drivers/hid/hid-logitech-hidpp.c:396: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * hidpp_prefix_name() prefixes the current given name with "Logitech ".
   drivers/hid/hid-logitech-hidpp.c:439: warning: Function parameter or struct member 'input_dev' not described in 'hidpp_scroll_counter_handle_scroll'
   drivers/hid/hid-logitech-hidpp.c:502: warning: Function parameter or struct member 'bit' not described in 'hidpp10_set_register_bit'
   drivers/hid/hid-logitech-hidpp.c:1468: warning: Function parameter or struct member 'hidpp' not described in 'hidpp_touchpad_fw_items_set'
   drivers/hid/hid-logitech-hidpp.c:1468: warning: Function parameter or struct member 'feature_index' not described in 'hidpp_touchpad_fw_items_set'
   drivers/hid/hid-logitech-hidpp.c:1468: warning: Function parameter or struct member 'items' not described in 'hidpp_touchpad_fw_items_set'
   drivers/hid/hid-logitech-hidpp.c:1468: warning: expecting prototype for send a set state command to the device by reading the current items(). Prototype was for hidpp_touchpad_fw_items_set() instead


vim +156 drivers/hid/hid-logitech-hidpp.c

5a2b190cddb9aa Peter Hutterer 2016-06-29  139  
4435ff2f09a2fc Harry Cutts    2018-12-05  140  /**
4435ff2f09a2fc Harry Cutts    2018-12-05  141   * struct hidpp_scroll_counter - Utility class for processing high-resolution
4435ff2f09a2fc Harry Cutts    2018-12-05  142   *                             scroll events.
4435ff2f09a2fc Harry Cutts    2018-12-05  143   * @dev: the input device for which events should be reported.
4435ff2f09a2fc Harry Cutts    2018-12-05  144   * @wheel_multiplier: the scalar multiplier to be applied to each wheel event
4435ff2f09a2fc Harry Cutts    2018-12-05  145   * @remainder: counts the number of high-resolution units moved since the last
4435ff2f09a2fc Harry Cutts    2018-12-05  146   *             low-resolution event (REL_WHEEL or REL_HWHEEL) was sent. Should
4435ff2f09a2fc Harry Cutts    2018-12-05  147   *             only be used by class methods.
4435ff2f09a2fc Harry Cutts    2018-12-05  148   * @direction: direction of last movement (1 or -1)
4435ff2f09a2fc Harry Cutts    2018-12-05  149   * @last_time: last event time, used to reset remainder after inactivity
4435ff2f09a2fc Harry Cutts    2018-12-05  150   */
4435ff2f09a2fc Harry Cutts    2018-12-05  151  struct hidpp_scroll_counter {
4435ff2f09a2fc Harry Cutts    2018-12-05  152  	int wheel_multiplier;
4435ff2f09a2fc Harry Cutts    2018-12-05  153  	int remainder;
4435ff2f09a2fc Harry Cutts    2018-12-05  154  	int direction;
4435ff2f09a2fc Harry Cutts    2018-12-05  155  	unsigned long long last_time;
4435ff2f09a2fc Harry Cutts    2018-12-05 @156  };
4435ff2f09a2fc Harry Cutts    2018-12-05  157  

:::::: The code at line 156 was first introduced by commit
:::::: 4435ff2f09a2fc43d1201d732e6e606b4d4b1ad5 HID: logitech: Enable high-resolution scrolling on Logitech mice

:::::: TO: Harry Cutts <hcutts@...omium.org>
:::::: CC: Benjamin Tissoires <benjamin.tissoires@...hat.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki