linux-kernel - Re: [PATCH v3 0/7] Enhance event delivery error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241219231956.GA75820@dev-dsk-iorlov-1b-d2eae488.eu-west-1.amazon.com>
Date: Thu, 19 Dec 2024 23:19:56 +0000
From: Ivan Orlov <iorlov@...zon.com>
To: Sean Christopherson <seanjc@...gle.com>
CC: <bp@...en8.de>, <dave.hansen@...ux.intel.com>, <mingo@...hat.com>,
	<pbonzini@...hat.com>, <shuah@...nel.org>, <tglx@...utronix.de>,
	<hpa@...or.com>, <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <x86@...nel.org>, <dwmw@...zon.co.uk>,
	<pdurrant@...zon.co.uk>, <jalliste@...zon.co.uk>
Subject: Re: [PATCH v3 0/7] Enhance event delivery error handling

On Wed, Dec 18, 2024 at 06:40:46PM -0800, Sean Christopherson wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> On Tue, 17 Dec 2024 18:14:51 +0000, Ivan Orlov wrote:
> > Currently, the unhandleable vectoring (e.g. when guest accesses MMIO
> > during vectoring) is handled differently on VMX and SVM: on VMX KVM
> > returns internal error, when SVM goes into infinite loop trying to
> > deliver an event again and again.
> >
> > This patch series eliminates this difference by returning a KVM internal
> > error when KVM can't emulate during vectoring for both VMX and SVM.
> >
> > [...]
> 
> Applied to kvm-x86 misc, thanks!  If you get a chance, please double check that
> I didn't fat-finger anything.
> 
> [1/7] KVM: x86: Add function for vectoring error generation
>       https://github.com/kvm-x86/linux/commit/11c98fa07a79
> [2/7] KVM: x86: Add emulation status for unhandleable vectoring
>       https://github.com/kvm-x86/linux/commit/5c9cfc486636
> [3/7] KVM: x86: Unprotect & retry before unhandleable vectoring check
>       https://github.com/kvm-x86/linux/commit/704fc6021b9e
> [4/7] KVM: VMX: Handle vectoring error in check_emulate_instruction
>       https://github.com/kvm-x86/linux/commit/47ef3ef843c0
> [5/7] KVM: SVM: Handle vectoring error in check_emulate_instruction
>       https://github.com/kvm-x86/linux/commit/7bd7ff99110a
> [6/7] selftests: KVM: extract lidt into helper function
>       https://github.com/kvm-x86/linux/commit/4e9427aeb957
> [7/7] selftests: KVM: Add test case for MMIO during vectoring
>       https://github.com/kvm-x86/linux/commit/62e41f6b4f36
> 
> --
> https://github.com/kvm-x86/linux/tree/next

Hi Sean,

The commits (and the messages specifically) look good to me, thanks a
lot for making the changelogs better! :)

Also, I ran the selftests for the `next` branch on both Intel and AMD
platforms, and all of them seem to pass.

--
Kind regards,
Ivan Orlov