linux-kernel - Re: [PATCH v2] i2c: imx: switch different pinctrl state in different system power status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM0PR0402MB39376D08D11CA4CCF6F88F29E8062@AM0PR0402MB3937.eurprd04.prod.outlook.com>
Date: Thu, 19 Dec 2024 07:02:28 +0000
From: Carlos Song <carlos.song@....com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
CC: "andi.shyti@...nel.org" <andi.shyti@...nel.org>, Frank Li
	<frank.li@....com>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: imx: switch different pinctrl state in different
 system power status

Thank you! I will fix it at V3.

> -----Original Message-----
> From: Oleksij Rempel <o.rempel@...gutronix.de>
> Sent: Thursday, December 19, 2024 2:02 PM
> To: Carlos Song <carlos.song@....com>
> Cc: andi.shyti@...nel.org; Frank Li <frank.li@....com>;
> kernel@...gutronix.de; shawnguo@...nel.org; s.hauer@...gutronix.de;
> festevam@...il.com; linux-i2c@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: [EXT] Re: [PATCH v2] i2c: imx: switch different pinctrl state in different
> system power status
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> On Wed, Dec 18, 2024 at 12:41:14PM +0800, Carlos Song wrote:
> > Switch different pinctrl state in different system power status.
> >
> > Signed-off-by: Carlos Song <carlos.song@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > ---
> > Change for V2:
> > - Add Frank reviewed-by. No code change.
> > ---
> >  drivers/i2c/busses/i2c-imx.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx.c
> > b/drivers/i2c/busses/i2c-imx.c index b6ed270dd04b..350346a7892c 100644
> > --- a/drivers/i2c/busses/i2c-imx.c
> > +++ b/drivers/i2c/busses/i2c-imx.c
> > @@ -1871,6 +1871,7 @@ static int i2c_imx_runtime_suspend(struct device
> *dev)
> >       struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev);
> >
> >       clk_disable(i2c_imx->clk);
> > +     pinctrl_pm_select_sleep_state(dev);
> >
> >       return 0;
> >  }
> > @@ -1880,6 +1881,7 @@ static int i2c_imx_runtime_resume(struct device
> *dev)
> >       struct imx_i2c_struct *i2c_imx = dev_get_drvdata(dev);
> >       int ret;
> >
> > +     pinctrl_pm_select_default_state(dev);
>
> Both pinctrl_pm_select_sleep_state() and
> pinctrl_pm_select_default_state() may fail. Please use return values.
>
> --
> Pengutronix e.K.                           |
> |
> Steuerwalder Str. 21                       |
> http://www.pen/
> gutronix.de%2F&data=05%7C02%7Ccarlos.song%40nxp.com%7C556bac4a4d18
> 45fe9c6e08dd1ff2b262%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7
> C638701849411172324%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOn
> RydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3
> D%3D%7C0%7C%7C%7C&sdata=Gd6mIwBSMo6f03z3rVIInaPZXQXhCeyFEHYYl
> ctBPZQ%3D&reserved=0  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686           | Fax:
> +49-5121-206917-5555 |