[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d0b06b7-1fed-43cc-93e2-9a5f7cd14ffb@linaro.org>
Date: Thu, 19 Dec 2024 09:16:38 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Renjiang Han <quic_renjiang@...cinc.com>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
Vikash Garodia <quic_vgarodia@...cinc.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: quic_vnagar@...cinc.com, quic_dikshita@...cinc.com,
konradybcio@...nel.org, linux-media@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, Stanimir Varbanov <stanimir.varbanov@...aro.org>
Subject: Re: [PATCH v5 3/3] media: dt-bindings: qcom-venus: Deprecate
video-decoder and video-encoder where applicable
On 19/12/2024 03:45, Renjiang Han wrote:
>
> On 12/18/2024 8:38 PM, Krzysztof Kozlowski wrote:
>>>> @@ -132,12 +132,4 @@ examples:
>>>> resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>,
>>>> <&videocc VIDEO_CC_MVS0C_CLK_ARES>;
>>>> reset-names = "bus", "core";
>>>> -
>>>> - video-decoder {
>>>> - compatible = "venus-decoder";
>>>> - };
>>>> -
>>>> - video-encoder {
>>>> - compatible = "venus-encoder";
>>>> - };
>>>> };
>>> It is working fine on QCS615.
>>> Tested-by: Renjiang Han<quic_renjiang@...cinc.com>
>> How? How is it possible to test a binding on real hardware? To my
>> knowledge it is impossible, so I really would like to see explanation of
>> this tag.
> I used this binding and modified the driver to verify the video
> function, and the result was fine. Also, I used this binding to
> verify the dtb, and there was no related error, so I added
> Tested-by.
This is not a testing of binding. You tested driver. Don't add fake tags.
Best regards,
Krzysztof
Powered by blists - more mailing lists