linux-kernel - Re: [PATCH] spi: atmel-qspi: Memory barriers after memory-mapped I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72874aa6-22c7-40a6-83bb-1ace0f3aec73@prolan.hu>
Date: Thu, 19 Dec 2024 10:09:50 +0100
From: Csókás Bence <csokas.bence@...lan.hu>
To: Mark Brown <broonie@...nel.org>
CC: Piotr Bugalski <bugalski.piotr@...il.com>, <linux-spi@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<Hari.PrasathGE@...rochip.com>, <Mahesh.Abotula@...rochip.com>,
	<Marco.Cardellini@...rochip.com>, <stable@...r.kernel.org>, Nicolas Ferre
	<nicolas.ferre@...rochip.com>, Alexandre Belloni
	<alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>
Subject: Re: [PATCH] spi: atmel-qspi: Memory barriers after memory-mapped I/O

Right. I originally planned on splitting it into a cover letter and then 
the patch, but I guess everything can just go into the msg. Dropping the ---

Bence

On 2024. 12. 18. 18:01, Mark Brown wrote:
> On Wed, Dec 18, 2024 at 05:58:49PM +0100, Bence Csókás wrote:
> 
>> However, the current documentation makes no mention to
>> synchronization requirements in the other direction, i.e.
>> after the last data written via AHB, and before the first
>> register access on APB.
>>
>> ---
>>
>> Fixes: d5433def3153 ("mtd: spi-nor: atmel-quadspi: Add spi-mem support to atmel-quadspi")
>> Cc: Hari.PrasathGE@...rochip.com
>> Cc: Mahesh.Abotula@...rochip.com
>> Cc: Marco.Cardellini@...rochip.com
>> Cc: <stable@...r.kernel.org> # c0a0203cf579: ("spi: atmel-quadspi: Create `atmel_qspi_ops`"...)
>> Cc: <stable@...r.kernel.org> # 6.x.y
>> Signed-off-by: Bence Csókás <csokas.bence@...lan.hu>
>> ---
> 
> Your signoffs and whatnot need to go before the --- so they don't get
> cut off by tools, any any ancilliary stuff should go after.