linux-kernel - Re: [PATCH] mtd: spi-nor: extend description of size member of struct flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r064c8r3.fsf@bootlin.com>
Date: Thu, 19 Dec 2024 10:38:56 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Renjun Wang <renjunw0@...mail.com>,  Pratyush Yadav
 <pratyush@...nel.org>,  Michael Walle <mwalle@...nel.org>,  Richard
 Weinberger <richard@....at>,  Vignesh Raghavendra <vigneshr@...com>,
  linux-mtd@...ts.infradead.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: extend description of size member of
 struct flash_info

On 19/12/2024 at 09:20:04 GMT, Tudor Ambarus <tudor.ambarus@...aro.org> wrote:

> We use the size as an indicator whether to parse SFDP or not. We don't
> introduce a dedicated member for SFDP parsing because we'd like to keep
> the struct size at a minimum, as it's used for every flash declaration.
> Ideally we won't have flash entries at all, but there are still flash
> parameters that aren't defined by SFDP, thus we need to statically
> specify them.

TBH I'd be perfectly fine (and prefer) a dedicated member, because
code clarity is IMO more important than memory footprint today.

However for now I am totally agreeing with changes clarifying what we
currently do, so:

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

One minor nit below though:

> + * @size:           the size of the flash in bytes. The flash size is one
> + *                  property parsed by the SFDP. We use it as an indicator
> + *                  whether we need SFDP parsing for a particular flash.
> + *                  I.e. non-legacy flash entries in flash_info will have
> + *                  a size of zero iff SFDP should be used.

typo, 'if'                            ^^^

Cheers,
Miquèl