linux-kernel - [PATCH v1] drivers/nouveau: change signature nv50_wndw_atomic_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241219100918.904082-1-den-plotnikov@yandex-team.ru>
Date: Thu, 19 Dec 2024 13:09:18 +0300
From: Denis Plotnikov <den-plotnikov@...dex-team.ru>
To: linux-kernel@...r.kernel.org
Cc: nouveau@...ts.freedesktop.org,
	dri-devel@...ts.freedesktop.org,
	dakr@...hat.com,
	lyude@...hat.com,
	kherbst@...hat.com
Subject: [PATCH v1] drivers/nouveau: change signature nv50_wndw_atomic_check_lut()

It always returned 0 so make it void instead of returning int.

Signed-off-by: Denis Plotnikov <den-plotnikov@...dex-team.ru>
---
 drivers/gpu/drm/nouveau/dispnv50/wndw.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/gpu/drm/nouveau/dispnv50/wndw.c
index f6be426dd5253..3ced5ebc3a897 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/wndw.c
@@ -370,7 +370,7 @@ nv50_wndw_atomic_check_acquire(struct nv50_wndw *wndw, bool modeset,
 	return wndw->func->acquire(wndw, asyw, asyh);
 }
 
-static int
+static void
 nv50_wndw_atomic_check_lut(struct nv50_wndw *wndw,
 			   struct nv50_wndw_atom *armw,
 			   struct nv50_wndw_atom *asyw,
@@ -392,7 +392,6 @@ nv50_wndw_atomic_check_lut(struct nv50_wndw *wndw,
 		 */
 		if (!(ilut = asyh->state.gamma_lut)) {
 			asyw->visible = false;
-			return 0;
 		}
 
 		if (wndw->func->ilut)
@@ -436,7 +435,6 @@ nv50_wndw_atomic_check_lut(struct nv50_wndw *wndw,
 
 	/* Can't do an immediate flip while changing the LUT. */
 	asyh->state.async_flip = false;
-	return 0;
 }
 
 static int
@@ -481,9 +479,7 @@ nv50_wndw_atomic_check(struct drm_plane *plane,
 	     asyh->state.color_mgmt_changed ||
 	     asyw->state.fb->format->format !=
 	     armw->state.fb->format->format)) {
-		ret = nv50_wndw_atomic_check_lut(wndw, armw, asyw, asyh);
-		if (ret)
-			return ret;
+		nv50_wndw_atomic_check_lut(wndw, armw, asyw, asyh);
 	}
 
 	/* Calculate new window state. */
-- 
2.34.1