linux-kernel - Re: [PATCH] KVM: VMX: don't include '<linux/find.h>' directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2QBu4qIsJERcbHF@shikoro>
Date: Thu, 19 Dec 2024 12:21:31 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org,
	Yury Norov <yury.norov@...il.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH] KVM: VMX: don't include '<linux/find.h>' directly

On Tue, Dec 17, 2024 at 08:37:27AM -0800, Sean Christopherson wrote:
> +Yury and Rasmus
> 
> On Tue, Dec 17, 2024, Wolfram Sang wrote:
> > The header clearly states that it does not want to be included directly,
> 
> I definitely don't object to the KVM change, but the if y'all expect developers
> to actually honor the "rule", it needs to have teeth.  As evidenced by a similar
> rule in arch/x86/include/asm/bitops.h that also gets ignored, an #error that's
> buried under an include guard and triggers on a macro that's never #undef'd is
> quite useless.

To follow up, I am willing to do the proposed change. But before sending
this out, it would be nice if the existing broken includes would be
fixed. So, can this patch be applied first?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)