linux-kernel - RE: wifi: iwlwifi: fix documentation about initial values in station table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW5PR11MB5810609CEE8C0830676215A7A3062@MW5PR11MB5810.namprd11.prod.outlook.com>
Date: Thu, 19 Dec 2024 11:51:08 +0000
From: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>
To: Rolf Eike Beer <eb@...ix.com>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Berg,
 Johannes" <johannes.berg@...el.com>
Subject: RE: wifi: iwlwifi: fix documentation about initial values in station
 table



> -----Original Message-----
> From: Rolf Eike Beer <eb@...ix.com>
> Sent: Thursday, 19 December 2024 12:22
> To: Korenblit, Miriam Rachel <miriam.rachel.korenblit@...el.com>
> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: wifi: iwlwifi: fix documentation about initial values in station table
> 
> The inverse value is stored in the table, make the documentation match the code.
> 
> Signed-off-by: Rolf Eike Beer <eb@...ix.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> b/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> index 4a3799ae7c18..dbc531c63f0f 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.h
> @@ -133,7 +133,7 @@ struct iwl_mvm_vif;
>   * and no TID data as this is also not needed.
>   * One thing to note, is that these stations have an ID in the fw, but not
>   * in mac80211. In order to "reserve" them a sta_id in %fw_id_to_mac_id
> - * we fill ERR_PTR(EINVAL) in this mapping and all other dereferencing of
> + * we fill ERR_PTR(-EINVAL) in this mapping and all other dereferencing of
>   * pointers from this mapping need to check that the value is not error
>   * or NULL.
>   *
> --
> 2.47.1
> 
> 
> --
> Rolf Eike Beer
> 
> emlix GmbH
> Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
> Phone +49 (0)551 30664-0, e-mail info@...ix.com
> District Court of Göttingen, Registry Number HR B 3160
> Managing Directors: Heike Jordan, Dr. Uwe Kracke
> VAT ID No. DE 205 198 055
> Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
> Office Bonn: Bachstr. 6, 53115 Bonn, Germany
> http://www.emlix.com
> 
> emlix - your embedded Linux partner
> 
Acked-by: Miri Korenblit <miriam.rachel.korenblit@...el.com>