linux-kernel - Re: [PATCH] selftests/bpf: Fix compilation error in get_uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <975c7d53-bbca-4ed7-9635-53f5741ee2ff@iogearbox.net>
Date: Thu, 19 Dec 2024 13:27:59 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Yonghong Song <yonghong.song@...ux.dev>,
 Jerome Marchand <jmarchan@...hat.com>, bpf@...r.kernel.org,
 Andrii Nakryiko <andrii@...nel.org>
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/bpf: Fix compilation error in
 get_uprobe_offset()

On 12/19/24 2:28 AM, Yonghong Song wrote:
> On 12/18/24 9:57 AM, Jerome Marchand wrote:
>> In get_uprobe_offset(), the call to procmap_query() use the constant
>> PROCMAP_QUERY_VMA_EXECUTABLE, even if PROCMAP_QUERY is not defined.
>>
>> Define PROCMAP_QUERY_VMA_EXECUTABLE when PROCMAP_QUERY isn't.
>>
>> Fixes: 4e9e07603ecd ("selftests/bpf: make use of PROCMAP_QUERY ioctl if available")
>> Signed-off-by: Jerome Marchand <jmarchan@...hat.com>
> 
> Acked-by: Yonghong Song <yonghong.song@...ux.dev>

lgtm, I've wrapped this in an ifndef while applying.