linux-kernel - Re: [PATCH 2/3] drm: bridge: adv7511: remove s32 format from i2s capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <749034d8-4b8f-43f8-b009-175a915b8967@foss.st.com>
Date: Thu, 19 Dec 2024 15:51:24 +0100
From: Olivier MOYSAN <olivier.moysan@...s.st.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart
	<Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej
 Skrabec <jernej.skrabec@...il.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] drm: bridge: adv7511: remove s32 format from i2s
 capabilities

Hi Dmitry,

On 12/11/24 23:54, Dmitry Baryshkov wrote:
> On Tue, Dec 10, 2024 at 02:42:53PM +0100, Olivier Moysan wrote:
>> The ADV7511 chip allows 24 bits samples max in I2S mode, excepted for
>> direct AES3 mode (SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE format).
>> However the HDMI codec exposes S32_LE format as supported.
>> Adapt ADV7511 HDMI I2S format list to expose formats actually supported.
>>
>> Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>
>> ---
>>   drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
>> index 28ae81ca3651..ce6eda87bfe0 100644
>> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
>> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
>> @@ -232,6 +232,9 @@ static const struct hdmi_codec_ops adv7511_codec_ops = {
>>   
>>   static const struct hdmi_codec_pdata codec_data = {
>>   	.ops = &adv7511_codec_ops,
>> +	.i2s_formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |
>> +			SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE |
>> +			SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE),
> 
> This will break w/o patch 3. Please change the order of the patches so
> that after each commit the kernel can still be built and work correctly.
> 

Right. I will re-order in v2.

>>   	.max_i2s_channels = 2,
>>   	.i2s = 1,
>>   	.no_i2s_capture = 1,
>> -- 
>> 2.25.1
>>
>