[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241219152519.4ac94595@jic23-huawei>
Date: Thu, 19 Dec 2024 15:25:19 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Per-Daniel Olsson <perdaniel.olsson@...s.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Javier Carrasco <javier.carrasco.cruz@...il.com>,
<linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>, <rickard.andersson@...s.com>,
<kernel@...s.com>
Subject: Re: [PATCH v10 0/2] Support for Texas Instruments OPT4060 RGBW
Color sensor.
On Wed, 18 Dec 2024 11:48:34 +0100
Per-Daniel Olsson <perdaniel.olsson@...s.com> wrote:
> This patch series adds support for Texas Instruments OPT4060 RGBW Color sensor
> using the i2c interface.
>
> The driver exposes raw adc values for red, green, blue and clear. The
> illuminance is exposed as a calculated value in lux, the calculation uses the
> wide spectrum green channel as base. The driver supports scale values for red,
> green and blue. The raw values are scaled so that for a particular test light
> source, typically white, the measurement intensity is the same across the
> different color channels. Integration time can be configured through sysfs as
> well. The OPT4060 sensor supports both rising and falling threshold interrupts.
> These interrupts are exposed as IIO events. The driver also implements an IIO
> triggered buffer with a trigger for conversion ready interrupts.
Looks good to me.
Applied to the togreg branch of iio.git and pushed out as testing for 0-day to
take a first look at it and see if it can find anything we missed.
Thanks,
Jonathan
Powered by blists - more mailing lists