linux-kernel - [PATCH AUTOSEL 6.12 19/29] ARC: bpf: Correct conditional check in 'check_jmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241220171130.511389-19-sashal@kernel.org>
Date: Fri, 20 Dec 2024 12:11:20 -0500
From: Sasha Levin <sashal@...nel.org>
To: linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Cc: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Shahab Vahedi <list+bpf@...edi.org>,
	Vineet Gupta <vgupta@...nel.org>,
	Sasha Levin <sashal@...nel.org>,
	ast@...nel.org,
	daniel@...earbox.net,
	andrii@...nel.org,
	bpf@...r.kernel.org,
	linux-snps-arc@...ts.infradead.org
Subject: [PATCH AUTOSEL 6.12 19/29] ARC: bpf: Correct conditional check in 'check_jmp_32'

From: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>

[ Upstream commit 7dd9eb6ba88964b091b89855ce7d2a12405013af ]

The original code checks 'if (ARC_CC_AL)', which is always true since
ARC_CC_AL is a constant. This makes the check redundant and likely
obscures the intention of verifying whether the jump is conditional.

Updates the code to check cond == ARC_CC_AL instead, reflecting the intent
to differentiate conditional from unconditional jumps.

Suggested-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Acked-by: Shahab Vahedi <list+bpf@...edi.org>
Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
Signed-off-by: Vineet Gupta <vgupta@...nel.org>
Signed-off-by: Sasha Levin <sashal@...nel.org>
---
 arch/arc/net/bpf_jit_arcv2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/net/bpf_jit_arcv2.c b/arch/arc/net/bpf_jit_arcv2.c
index 4458e409ca0a..6d989b6d88c6 100644
--- a/arch/arc/net/bpf_jit_arcv2.c
+++ b/arch/arc/net/bpf_jit_arcv2.c
@@ -2916,7 +2916,7 @@ bool check_jmp_32(u32 curr_off, u32 targ_off, u8 cond)
 	addendum = (cond == ARC_CC_AL) ? 0 : INSN_len_normal;
 	disp = get_displacement(curr_off + addendum, targ_off);
 
-	if (ARC_CC_AL)
+	if (cond == ARC_CC_AL)
 		return is_valid_far_disp(disp);
 	else
 		return is_valid_near_disp(disp);
-- 
2.39.5