linux-kernel - Re: [PATCH 6/8] input: keyboard: Add support for MAX7360 keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412210024.DavK6KEl-lkp@intel.com>
Date: Sat, 21 Dec 2024 01:12:11 +0800
From: kernel test robot <lkp@...el.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>,
	Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Kamel Bouhara <kamel.bouhara@...tlin.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Uwe Kleine-König <ukleinek@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-input@...r.kernel.org,
	linux-pwm@...r.kernel.org,
	Grégory Clement <gregory.clement@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
Subject: Re: [PATCH 6/8] input: keyboard: Add support for MAX7360 keypad

Hi Mathieu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8]

url:    https://github.com/intel-lab-lkp/linux/commits/Mathieu-Dubois-Briand/dt-bindings-Add-MAX7360-MFD-device/20241220-002541
base:   78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
patch link:    https://lore.kernel.org/r/20241219-mdb-max7360-support-v1-6-8e8317584121%40bootlin.com
patch subject: [PATCH 6/8] input: keyboard: Add support for MAX7360 keypad
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20241221/202412210024.DavK6KEl-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241221/202412210024.DavK6KEl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412210024.DavK6KEl-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/input/keyboard/max7360-keypad.c:105:24: warning: implicit conversion from 'unsigned long' to 'unsigned int' changes value from 18446744073709551487 to 4294967167 [-Wconstant-conversion]
     104 |         ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG,
         |               ~~~~~~~~~~~~~~~~~
     105 |                                 MAX7360_CFG_SLEEP, ~MAX7360_CFG_SLEEP);
         |                                                    ^~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +105 drivers/input/keyboard/max7360-keypad.c

    95	
    96	static void max7360_keypad_close(struct input_dev *pdev)
    97	{
    98		struct max7360_keypad *max7360_keypad = input_get_drvdata(pdev);
    99		int ret;
   100	
   101		/*
   102		 * Nobody is using the device anymore: go to sleep.
   103		 */
   104		ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG,
 > 105					MAX7360_CFG_SLEEP, ~MAX7360_CFG_SLEEP);
   106		if (ret) {
   107			dev_err(&max7360_keypad->input->dev,
   108				"Failed to write max7360 configuration");
   109		}
   110	}
   111	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki