linux-kernel - Re: [PATCH v10 07/24] x86/resctrl: Add support to enable/disable AMD ABMC feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551265b5-dc7b-4a31-8288-c201684ecf08@intel.com>
Date: Fri, 20 Dec 2024 09:16:42 -0800
From: Reinette Chatre <reinette.chatre@...el.com>
To: "Moger, Babu" <bmoger@....com>, Babu Moger <babu.moger@....com>,
	<corbet@....net>, <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
	<dave.hansen@...ux.intel.com>, <tony.luck@...el.com>,
	<peternewman@...gle.com>
CC: <fenghua.yu@...el.com>, <x86@...nel.org>, <hpa@...or.com>,
	<paulmck@...nel.org>, <akpm@...ux-foundation.org>, <thuth@...hat.com>,
	<rostedt@...dmis.org>, <xiongwei.song@...driver.com>,
	<pawan.kumar.gupta@...ux.intel.com>, <daniel.sneddon@...ux.intel.com>,
	<jpoimboe@...nel.org>, <perry.yuan@....com>, <kai.huang@...el.com>,
	<xiaoyao.li@...el.com>, <seanjc@...gle.com>, <xin3.li@...el.com>,
	<andrew.cooper3@...rix.com>, <ebiggers@...gle.com>,
	<mario.limonciello@....com>, <james.morse@....com>,
	<tan.shaopeng@...itsu.com>, <linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <maciej.wieczor-retman@...el.com>,
	<eranian@...gle.com>
Subject: Re: [PATCH v10 07/24] x86/resctrl: Add support to enable/disable AMD
 ABMC feature

Hi Babu,

On 12/20/24 7:14 AM, Moger, Babu wrote:
> Hi Reinette,
> 
> On 12/19/2024 3:48 PM, Reinette Chatre wrote:
>> Hi Babu,
>>
>> On 12/12/24 12:15 PM, Babu Moger wrote:
>>
>>>   static inline struct rdt_hw_resource *resctrl_to_arch_res(struct rdt_resource *r)
>>> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> index 687d9d8d82a4..d54c2701c09c 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
>>
>> These functions are clearly monitoring related. Is there a reason why they are
>> in rdtgroup.c and not in monitor.c?
> 
> There is no specific reason. Most of these functions are called from user interface. User interface handlers are defined in rdtgroup.c.
> 

Most, but not all of them, are, yes. With most operations triggered via user
interface we'll end up with most code in the same file if trying to keep all code
triggered by user space together.

> All the code in this series is related to monitoring. We can move everything to monitor.c if you are ok with it.

The read/write callbacks could stay with res_common_files[] to make their definition
simpler. I think it would make things clear if these callback functions call into monitoring
code located in monitor.c. Since you have been staring at this much longer, please let me know
if you find this to actually make things harder to follow and find.

Reinette