linux-kernel - Re: [PATCH 5/5] squashfs: Convert squashfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2W2Z2Tq4WMNluWU@casper.infradead.org>
Date: Fri, 20 Dec 2024 18:24:39 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Phillip Lougher <phillip@...ashfs.org.uk>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 5/5] squashfs: Convert squashfs_fill_page() to take a
 folio

On Fri, Dec 20, 2024 at 06:19:35PM +0000, Phillip Lougher wrote:
> > @@ -398,6 +400,7 @@ void squashfs_copy_cache(struct folio *folio,
> >   			bytes -= PAGE_SIZE, offset += PAGE_SIZE) {
> >   		struct folio *push_folio;
> >   		size_t avail = buffer ? min(bytes, PAGE_SIZE) : 0;
> > +		bool filled = false;

ahh, this should have been filled = true (if the folio is already
uptodate, then it has been filled).  Or maybe it'd be less confusing if
we named the bool 'uptodate'.

Would you like me to submit a fresh set of patches, or will you fix
these two bugs up?

Thanks for testing!