linux-kernel - Re: [PATCH v6 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM7P189MB1009DBCC9F40EDC3852E14D2E3072@AM7P189MB1009.EURP189.PROD.OUTLOOK.COM>
Date: Fri, 20 Dec 2024 19:46:39 +0100
From: Maud Spierings <maud_spierings@...mail.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Johan Hovold <johan@...nel.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add
 bluetooth

On 12/20/24 6:50 PM, Stephan Gerhold wrote:
> On Wed, Dec 04, 2024 at 01:26:39PM +0100, Maud Spierings via B4 Relay wrote:
>> From: Maud Spierings <maud_spierings@...mail.com>
>>
>> Add bluetooth for the asus vivobook s15
>> Describe wlan configuration
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> Signed-off-by: Maud Spierings <maud_spierings@...mail.com>
>> ---
>>   .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts   | 161 +++++++++++++++++++++
>>   1 file changed, 161 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
>> index ba52c0eef4e32019f6eb7c7ae3c4cd727df23490..6564386e92e5c8c08ae2807ba512f83537358cf5 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
>> @@ -19,6 +19,10 @@ / {
>>   	compatible = "asus,vivobook-s15", "qcom,x1e80100";
>>   	chassis-type = "laptop";
>>   
>> +	aliases {
>> +		serial1 = &uart14;
>> +	};
>> +
>>   	gpio-keys {
>>   		compatible = "gpio-keys";
>>   		pinctrl-0 = <&hall_int_n_default>;
>> @@ -153,6 +157,101 @@ vph_pwr: regulator-vph-pwr {
>>   		regulator-always-on;
>>   		regulator-boot-on;
>>   	};
>> +
>> +	vreg_wcn_0p95: regulator-wcn-0p95 {
>> +		compatible = "regulator-fixed";
>> +
>> +		regulator-name = "VREG_WCN_0P95";
>> +		regulator-min-microvolt = <950000>;
>> +		regulator-max-microvolt = <950000>;
>> +
>> +		vin-supply = <&vreg_wcn_3p3>;
>> +	};
>> +
>> +	vreg_wcn_1p9: regulator-wcn-1p9 {
>> +		compatible = "regulator-fixed";
>> +
>> +		regulator-name = "VREG_WCN_1P9";
>> +		regulator-min-microvolt = <1900000>;
>> +		regulator-max-microvolt = <1900000>;
>> +
>> +		vin-supply = <&vreg_wcn_3p3>;
>> +	};
> The reason we haven't pushed these patches for CRD, T14s etc is that
> unlike for QCP these two regulators are not actually present on the
> mainboard, they are part of a soldered or removable M.2 card. You can
> find this TODO in the commit message/patch on Johan's kernel tree:
>
> https://github.com/jhovold/linux/commit/32cfeff737b0f9a2f8787d21a875e549a22e9e8b
> https://github.com/jhovold/linux/commit/2a7fee4007670e2f0f7696eb9e992e74d3be460f
>
> We haven't come to a conclusion yet how to model these M.2 cards
> properly. Perhaps we should stop blocking this and merge this for all
> the laptops as temporary solution to get Bluetooth running, but then we
> should at least preserve the TODO comment block to make that clear:
>
> 	/*
> 	 * TODO: These two regulators are actually part of the removable M.2
> 	 * card and not the CRD mainboard. Need to describe this differently.
> 	 * Functionally it works correctly, because all we need to do is to
> 	 * turn on the actual 3.3V supply above.
> 	 */
>
> @Konrad: Given that you acked this patch, do you have any opinion if we
> should merge these with this open question?
>
> Thanks,
> Stephan
It is soldered down in the case of the asus vivobook s15 see:
https://laptopmedia.com/wp-content/uploads/2024/06/IMG_20240618_161453_1-scaled.jpg

I don't know if this regulator is underneath this metal shield or if it 
is actually separate on the board in this case.

But given that it is not a replaceable m.2 module isn't it kind of part 
of the mainboard anyway?

Anyways if it does come to having to add the TODO comment I'll fix it up 
in a v7

kind regards,
Maud Spierings