linux-kernel - [PATCH RESEND 0/1] Do Not Disturb broke GD D-pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241220192318.1174945-1-terry.tritton@linaro.org>
Date: Fri, 20 Dec 2024 19:23:17 +0000
From: Terry Tritton <terry.tritton@...aro.org>
To: Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org,
	Aseda Aboagye <aaboagye@...omium.org>,
	Peter Griffin <peter.griffin@...aro.org>,
	Terry Tritton <ttritton@...gle.com>,
	Carlos Llamas <cmllamas@...gle.com>,
	Terry Tritton <terry.tritton@...aro.org>
Subject: [PATCH RESEND 0/1] Do Not Disturb broke GD D-pad 

Hi, 
We noticed a breakage in the android test: CtsHardwareTestCases_cts_tests
android.hardware.input.cts.tests.GameviceGv186Test#testAllMotions

I bisected the issue to:
	commit 22d6d060ac77 ("input: Add support for "Do Not Disturb"")
The cause is pretty clear there are 2 separate checks for:
	if ((usage->hid & 0xf0) == 0x90)
so the second one which handles the d-pad is getting skipped.

I've combined them both in the following patch which works for me.

Resending with reviewers tagged from previous discussion[1]

Thanks

[1] https://lore.kernel.org/linux-input/20241011195808.2201-1-terry.tritton@linaro.org/

Terry Tritton (1):
  input: fix generic desktop D-Pad controls

 drivers/hid/hid-input.c | 37 +++++++++++++++++--------------------
 include/linux/hid.h     |  1 +
 2 files changed, 18 insertions(+), 20 deletions(-)

-- 
2.39.5