linux-kernel - Re: [PATCH v1 3/3] perf annotate: Prefer passing evsel to evsel->core.idx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2XKjPau1uPgKqro@x1>
Date: Fri, 20 Dec 2024 16:50:36 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>,
	Chen Ni <nichen@...as.ac.cn>, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] perf annotate: Prefer passing evsel to
 evsel->core.idx

On Thu, Nov 14, 2024 at 03:07:13PM -0800, Ian Rogers wrote:
> An evsel idx may not be stable due to sorting, evlist removal,
> etc. Try to reduce it being part of APIs by explicitly passing the
> evsel in annotate code. Internally the code just reads evsel->core.idx
> so behavior is unchanged.

I think this is where this comes into play, are you running 'make -C
tools/perf tools-build' before submitting?

I'll have to stop now, but will fix this if you don´t have time for a
v2.

- Arnaldo

ui/gtk/annotate.c: In function ‘perf_gtk__get_percent’:
ui/gtk/annotate.c:45:48: error: passing argument 2 of ‘annotation__histogram’ makes pointer from integer without a cast [-Wint-conversion]
   45 |         symhist = annotation__histogram(notes, evidx);
      |                                                ^~~~~
      |                                                |
      |                                                int
In file included from ui/gtk/annotate.c:5:
/home/acme/git/perf-tools-next/tools/perf/util/annotate.h:383:74: note: expected ‘const struct evsel *’ but argument is of type ‘int’
  383 |                                                      const struct evsel *evsel)
      |                                                      ~~~~~~~~~~~~~~~~~~~~^~~~~
ui/gtk/annotate.c:46:58: error: passing argument 2 of ‘annotated_source__hist_entry’ makes pointer from integer without a cast [-Wint-conversion]
   46 |         entry = annotated_source__hist_entry(notes->src, evidx, dl->al.offset);
      |                                                          ^~~~~
      |                                                          |
      |                                                          int
/home/acme/git/perf-tools-next/tools/perf/util/annotate.h:389:80: note: expected ‘const struct evsel *’ but argument is of type ‘int’
  389 | annotated_source__hist_entry(struct annotated_source *src, const struct evsel *evsel, u64 offset)
      |                                                            ~~~~~~~~~~~~~~~~~~~~^~~~~
  TEST    tests/shell/test_task_analyzer.sh.shellcheck_log
make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:105: ui/gtk/annotate.o] Error 1
  TEST    tests/shell/test_uprobe_from_different_cu.sh.shellcheck_log
  CC      util/session.o
make[5]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:158: ui/gtk] Error 2
make[4]: *** [Makefile.perf:802: gtk-in.o] Error 2
make[4]: *** Waiting for unfinished jobs....
  CC      util/tool.o