linux-kernel - Re: [RESEND PATCH] apparmor: Use str_yes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d93ed7bb-b184-4153-8084-b693eb1e2b85@canonical.com>
Date: Fri, 20 Dec 2024 12:19:46 -0800
From: John Johansen <john.johansen@...onical.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>, Paul Moore
 <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
 "Serge E. Hallyn" <serge@...lyn.com>
Cc: apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] apparmor: Use str_yes_no() helper function

On 12/20/24 11:22, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.
> 
> Fix a typo in a comment: s/unpritable/unprintable/
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Hey Thorsten,

sorry for the delay on this I am just really backlogged and will try to catch-up
on the mailing list traffic this weekend.

Acked-by: John Johansen <john.johansen@...onical.com>

I have pulled this into my tree and it should migrate into linux-next soon

> ---
>   security/apparmor/apparmorfs.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
> index 2c0185ebc900..1bce9a7d2129 100644
> --- a/security/apparmor/apparmorfs.c
> +++ b/security/apparmor/apparmorfs.c
> @@ -997,7 +997,7 @@ static int aa_sfs_seq_show(struct seq_file *seq, void *v)
>   
>   	switch (fs_file->v_type) {
>   	case AA_SFS_TYPE_BOOLEAN:
> -		seq_printf(seq, "%s\n", fs_file->v.boolean ? "yes" : "no");
> +		seq_printf(seq, "%s\n", str_yes_no(fs_file->v.boolean));
>   		break;
>   	case AA_SFS_TYPE_STRING:
>   		seq_printf(seq, "%s\n", fs_file->v.string);
> @@ -1006,7 +1006,7 @@ static int aa_sfs_seq_show(struct seq_file *seq, void *v)
>   		seq_printf(seq, "%#08lx\n", fs_file->v.u64);
>   		break;
>   	default:
> -		/* Ignore unpritable entry types. */
> +		/* Ignore unprintable entry types. */
>   		break;
>   	}
>   
> @@ -1152,7 +1152,7 @@ static int seq_ns_stacked_show(struct seq_file *seq, void *v)
>   	struct aa_label *label;
>   
>   	label = begin_current_label_crit_section();
> -	seq_printf(seq, "%s\n", label->size > 1 ? "yes" : "no");
> +	seq_printf(seq, "%s\n", str_yes_no(label->size > 1));
>   	end_current_label_crit_section(label);
>   
>   	return 0;
> @@ -1175,7 +1175,7 @@ static int seq_ns_nsstacked_show(struct seq_file *seq, void *v)
>   			}
>   	}
>   
> -	seq_printf(seq, "%s\n", count > 1 ? "yes" : "no");
> +	seq_printf(seq, "%s\n", str_yes_no(count > 1));
>   	end_current_label_crit_section(label);
>   
>   	return 0;