linux-kernel - Re: [PATCH v3] drm/msm/a6xx: Add support for Adreno 612

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jsuzytkpcs7xmsaaedypz6w5d4ia6rckxjqg2x7mp4sidxxtqk@t5ukbn3sv6oa>
Date: Fri, 20 Dec 2024 22:58:58 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Akhil P Oommen <quic_akhilpo@...cinc.com>, 
	Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>, 
	Konrad Dybcio <konradybcio@...nel.org>, Abhinav Kumar <quic_abhinavk@...cinc.com>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Jie Zhang <quic_jiezh@...cinc.com>
Subject: Re: [PATCH v3] drm/msm/a6xx: Add support for Adreno 612

On Fri, Dec 20, 2024 at 08:56:31PM +0100, Konrad Dybcio wrote:
> On 13.12.2024 12:46 PM, Akhil P Oommen wrote:
> > From: Jie Zhang <quic_jiezh@...cinc.com>
> > 
> > Add support for Adreno 612 GPU found in SM6150/QCS615 chipsets.
> > A612 falls under ADRENO_6XX_GEN1 family and is a cut down version
> > of A615 GPU.
> > 
> > A612 has a new IP called Reduced Graphics Management Unit or RGMU
> > which is a small state machine which helps to toggle GX GDSC
> > (connected to CX rail) to implement IFPC feature. It doesn't support
> > any other features of a full fledged GMU like clock control, resource
> > voting to rpmh etc. So we need linux clock driver support like other
> > gmu-wrapper implementations to control gpu core clock and gpu GX gdsc.
> > Since there is no benefit with enabling RGMU at the moment, RGMU is
> > entirely skipped in this patch.
> > 
> > Signed-off-by: Jie Zhang <quic_jiezh@...cinc.com>
> > Signed-off-by: Akhil P Oommen <quic_akhilpo@...cinc.com>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> > ---
> 
> So we talked offline a bit, and the RGMU requires a piece of firmware.
> 
> We concluded it's best to describe that from the get-go, so that the
> user doesn't get surprised when a new kernel update brings new firmware
> requirements for previously-working hardware.

I'd say, please make sure that the RGMU firmware is also a part of the
linux-firmware from the beginning.

> 
> Please wait for the new revision.
> 
> Konrad

-- 
With best wishes
Dmitry