linux-kernel - Re: [PATCH] kdb: use kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=UT0SHrNSLHgBJXjajoWLvdSNtSV1kGdsbDxfc_m_FBjQ@mail.gmail.com>
Date: Fri, 20 Dec 2024 13:18:50 -0800
From: Doug Anderson <dianders@...omium.org>
To: zhangheng <zhangheng@...inos.cn>
Cc: jason.wessel@...driver.com, danielt@...nel.org, 
	kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kdb: use kmap_local_page()

Hi,

On Fri, Dec 20, 2024 at 2:25 AM zhangheng <zhangheng@...inos.cn> wrote:
>
> Use kmap_local_page() instead of kmap_atomic() which has been deprecated.
>
> Signed-off-by: zhangheng <zhangheng@...inos.cn>

nit: The fact that the "name" part of this is in all lowercase and
matches your email address makes me think you're lacking the "name"
part of your git config. Is "zhangheng" how you normally identify
yourself, or should there be spaces / capitalization? An Internet
search makes me think maybe this should be "Zhang Heng" ?

> ---
>  kernel/debug/kdb/kdb_support.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I wasn't up on the whole kmap_atomic() deprecation, but LWN to the
rescue [1]. With that context, this looks fine to me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>

[1] https://lwn.net/Articles/836144/