linux-kernel - Re: [PATCH 4/8] pwm: max7360: Add MAX7360 PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6gpiriu4n5c324pkl354uews5prlqsrapoxupu5liu6fd5ruc@swtw4eebk7et>
Date: Fri, 20 Dec 2024 06:51:12 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: mathieu.dubois-briand@...tlin.com
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Kamel Bouhara <kamel.bouhara@...tlin.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-input@...r.kernel.org, linux-pwm@...r.kernel.org, 
	Grégory Clement <gregory.clement@...tlin.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 4/8] pwm: max7360: Add MAX7360 PWM support

Hello again,

On Thu, Dec 19, 2024 at 05:21:21PM +0100, mathieu.dubois-briand@...tlin.com wrote:
> diff --git a/drivers/pwm/pwm-max7360.c b/drivers/pwm/pwm-max7360.c
> new file mode 100644
> index 000000000000..b1cde3e86864
> --- /dev/null
> +++ b/drivers/pwm/pwm-max7360.c
> @@ -0,0 +1,173 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright 2024 Bootlin
> + *

I forgot: Please also add a paragraph here describing the relevant
features here in the format that several other drivers use. Such that

	sed -rn '/Limitations:/,/\*\/?$/p' drivers/pwm/*.c

emits it. Relevant are at least:

 - Only supports normal polarity

 - How does it behave on disable? (Constant low? Freeze at the level
   where it just happens to be? High-Z?)

 - How does it behave on reconfiguration? (counter reset? Mixed output
   possible?

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)