linux-kernel - Re: [PATCHv2] media: venc: destroy hfi session after m2m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ga4g3k7j6hx3qs243lcsfyzpuonh3wvxjareaurlg6e246xf7i@xdlg4l42fnuc>
Date: Fri, 20 Dec 2024 08:03:56 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Stanimir Varbanov <stanimir.k.varbanov@...il.com>, 
	Vikash Garodia <quic_vgarodia@...cinc.com>, Bryan O'Donoghue <bryan.odonoghue@...aro.org>, 
	Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCHv2] media: venc: destroy hfi session after m2m_ctx release

On Fri, Dec 20, 2024 at 01:32:48PM +0900, Sergey Senozhatsky wrote:
> On (24/12/19 15:12), Dmitry Baryshkov wrote:
> > On Thu, Dec 19, 2024 at 02:37:08PM +0900, Sergey Senozhatsky wrote:
> > > This partially reverts commit that made hfi_session_destroy()
> > > the first step of vdec/venc close().  The reason being is a
> > > regression report when, supposedly, encode/decoder is closed
> > > with still active streaming (no ->stop_streaming() call before
> > > close()) and pending pkts, so isr_thread cannot find instance
> > > and fails to process those pending pkts.  This was the idea
> > > behind the original patch - make it impossible to use instance
> > > under destruction, because this is racy, but apparently there
> > > are uses cases that depend on that unsafe pattern.  Return to
> > > the old (unsafe) behaviour for the time being (until a better
> > > fix is found).
> > 
> > You are describing a regression. Could you please add corresponding
> > Reported-by and Closes tags (for now you can post them in a reply to
> > your patch, in future please include them in your commit message).
> 
> The regression report is internal, I don't have anything public.
> One of the teams found out that some of their tests started to
> fail.

Still you probably can have a Repored-by, unless it's anonymous report.

> 
> > > Fixes: 45b1a1b348ec ("media: venus: sync with threaded IRQ during inst destruction")
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Sergey Senozhatsky <senozhatsky@...omium.org>
> > 
> > This is v2, but there is no changelog. Please provide one.
> 
> The code is obviously the same, I only added Cc: stable and removed
> one extra character in commit id "45b1a1b348ec".

This is the changelog. It helps reviewers to understand that there were
no code changes between versions.

-- 
With best wishes
Dmitry