linux-kernel - Re: [PATCH v3 1/3] rust: error: Change `LayoutError` to internal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241220061616.308635-1-jtostler1@gmail.com>
Date: Thu, 19 Dec 2024 22:15:52 -0800
From: Jimmy Ostler <jtostler1@...il.com>
To: dakr@...nel.org
Cc: a.hindborg@...nel.org,
	alex.gaynor@...il.com,
	alexmantel93@...lbox.org,
	aliceryhl@...gle.com,
	benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com,
	boqun.feng@...il.com,
	daniel@...lak.dev,
	felipe_life@...e.com,
	gary@...yguo.net,
	jtostler1@...il.com,
	kernel@...entinobst.de,
	linux-kernel@...r.kernel.org,
	miguel.ojeda.sandonis@...il.com,
	ojeda@...nel.org,
	rust-for-linux@...r.kernel.org,
	tmgross@...ch.edu,
	walmeida@...rosoft.com
Subject: Re: [PATCH v3 1/3] rust: error: Change `LayoutError` to internal

On Wed, Dec 18, 2024 at 4:43 AM Danilo Krummrich <dakr@...nel.org> wrote:
>
> On Wed, Dec 18, 2024 at 01:57:29AM +0100, Miguel Ojeda wrote:
> > On Wed, Dec 18, 2024 at 1:24 AM Jimmy Ostler <jtostler1@...il.com> wrote:
> > >
> > > Add an implementation of `From<LayoutError> for Error` for the
> > > `kernel::alloc::layout::LayoutError`.
> > > Remove the implementation on `core::alloc::LayoutError`, because we
> > > don't use it anywhere.
> >
> > No need to send a new version for this, but it may make sense to
> > reword to clarify that this switches the import, and therefore the
> > `impl` switches from one to the other. The way it is written, it
> > sounds like an actual `impl` item was textually added and another one
> > removed.
>
> Agree with Miguel, the commit message is slightly misleading.

That's a good point, I can reword that.

> With that fixed,

I'll submit a v4 with that fixed, thanks.

> Acked-by: Danilo Krummrich <dakr@...nel.org>
>
> >
> > Cheers,
> > Miguel

Thanks,
Jimmy Ostler