linux-kernel - Re: [PATCH] lockdep: Fix wait context check on softirq for PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241220071554.YAD157bS@linutronix.de>
Date: Fri, 20 Dec 2024 08:15:54 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Boqun Feng <boqun.feng@...il.com>
Cc: Ryo Takakura <ryotkkr98@...il.com>, peterz@...radead.org,
	clrkwllms@...nel.org, linux-kernel@...r.kernel.org,
	linux-rt-devel@...ts.linux.dev, longman@...hat.com,
	mingo@...hat.com, rostedt@...dmis.org, tglx@...utronix.de,
	will@...nel.org
Subject: Re: [PATCH] lockdep: Fix wait context check on softirq for PREEMPT_RT

On 2024-12-19 14:27:11 [-0800], Boqun Feng wrote:
> diff --git a/include/linux/bottom_half.h b/include/linux/bottom_half.h
> index fc53e0ad56d9..7191a753e983 100644
> --- a/include/linux/bottom_half.h
> +++ b/include/linux/bottom_half.h
> @@ -4,6 +4,7 @@
>  
>  #include <linux/instruction_pointer.h>
>  #include <linux/preempt.h>
> +#include <linux/lockdep.h>
>  
>  #if defined(CONFIG_PREEMPT_RT) || defined(CONFIG_TRACE_IRQFLAGS)
>  extern void __local_bh_disable_ip(unsigned long ip, unsigned int cnt);
> @@ -15,9 +16,12 @@ static __always_inline void __local_bh_disable_ip(unsigned long ip, unsigned int
>  }
>  #endif
>  
> +extern struct lockdep_map bh_lock_map;
> +
>  static inline void local_bh_disable(void)
>  {
>  	__local_bh_disable_ip(_THIS_IP_, SOFTIRQ_DISABLE_OFFSET);
> +	lock_map_acquire_read(&bh_lock_map);
>  }

Could you put this before __local_bh_disable_ip(), please?

Sebastian