linux-kernel - Re: [PATCH RESEND] VMCI: remove unused ioctl definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024122055-fall-publisher-6f76@gregkh>
Date: Fri, 20 Dec 2024 08:17:23 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alyssa Ross <hi@...ssa.is>
Cc: Arnd Bergmann <arnd@...db.de>,
	"open list:VMWARE VMCI DRIVER" <linux-kernel@...r.kernel.org>,
	Bryan Tan <bryan-bt.tan@...adcom.com>,
	Vishnu Dasa <vishnu.dasa@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH RESEND] VMCI: remove unused ioctl definitions

On Fri, Dec 20, 2024 at 12:29:57AM +0100, Alyssa Ross wrote:
> IOCTL_VMCI_SOCKETS_VERSION and IOCTL_VMCI_SOCKETS_GET_AF_VALUE were
> never implemented, because VSOCK ended up being implemented as a
> generic mechanism with a static AF value.  Likewise,
> IOCTL_VMCI_SOCKETS_GET_LOCAL_CID ended up being implemented as
> IOCTL_VM_SOCKETS_GET_LOCAL_CID.
> 
> This isn't a UAPI header, so it should be fine to remove the unused
> values.  I've left a comment noting IOCTL_VM_SOCKETS_GET_LOCAL_CID is
> in the VMCI range to avoid unintentional reuse.
> 
> Signed-off-by: Alyssa Ross <hi@...ssa.is>
> ---
> Hi misc maintainers!  I'm sending this version of the patch to you
> because the VMWare VMCI maintainers don't seem to be around any more.
> The last message on lore from either of them was in May.  Since then,
> I've submitted this patch twice, and haven't heard anything in response.
> 
>  include/linux/vmw_vmci_defs.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h
> index 6fb663b36f72..c2df94696593 100644
> --- a/include/linux/vmw_vmci_defs.h
> +++ b/include/linux/vmw_vmci_defs.h
> @@ -453,9 +453,7 @@ enum {
>  #define IOCTL_VMCI_CTX_GET_CPT_STATE		_IO(7, 0xb1)
>  #define IOCTL_VMCI_CTX_SET_CPT_STATE		_IO(7, 0xb2)
>  #define IOCTL_VMCI_GET_CONTEXT_ID		_IO(7, 0xb3)
> -#define IOCTL_VMCI_SOCKETS_VERSION		_IO(7, 0xb4)
> -#define IOCTL_VMCI_SOCKETS_GET_AF_VALUE		_IO(7, 0xb8)
> -#define IOCTL_VMCI_SOCKETS_GET_LOCAL_CID	_IO(7, 0xb9)
> +/*IOCTL_VM_SOCKETS_GET_LOCAL_CID		_IO(7, 0xb9)*/

Why is just this one left as a comment?  Shoudn't you just delet them
all?

thanks,

greg k-h