linux-kernel - RE: [PATCH] drm: xlnx: zynqmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB596939BC3BB3E228DAB8415A9C072@BL1PR12MB5969.namprd12.prod.outlook.com>
Date: Fri, 20 Dec 2024 08:31:42 +0000
From: "Sagar, Vishal" <vishal.sagar@....com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, Laurent Pinchart
	<laurent.pinchart@...asonboard.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>, Jonathan Corbet <corbet@....net>, "Simek,
 Michal" <michal.simek@....com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm: xlnx: zynqmp_dpsub: Fix kernel doc

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Tomi,

Thanks for the patch.

> -----Original Message-----
> From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Sent: Friday, December 20, 2024 8:30 AM
> To: Laurent Pinchart <laurent.pinchart@...asonboard.com>; Maarten Lankhorst
> <maarten.lankhorst@...ux.intel.com>; Maxime Ripard <mripard@...nel.org>;
> Thomas Zimmermann <tzimmermann@...e.de>; David Airlie
> <airlied@...il.com>; Simona Vetter <simona@...ll.ch>; Jonathan Corbet
> <corbet@....net>; Simek, Michal <michal.simek@....com>; Sagar, Vishal
> <vishal.sagar@....com>
> Cc: dri-devel@...ts.freedesktop.org; linux-doc@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Tomi Valkeinen
> <tomi.valkeinen@...asonboard.com>
> Subject: [PATCH] drm: xlnx: zynqmp_dpsub: Fix kernel doc
>
> Fix two kernel doc warnings introduced by the recent DP audio patch:
>
> - Add a doc line for the new "audio" field
> - Remove a reference to zynqmp_dpsub.c from zynqmp.rst, as the .c file
>   no longer has structured comments
>
> Fixes: 3ec5c1579305 ("drm: xlnx: zynqmp_dpsub: Add DP audio support")
> Closes: https://lore.kernel.org/all/20241220154208.720d990b@canb.auug.org.au/
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> ---
>  Documentation/gpu/zynqmp.rst        | 2 --
>  drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/gpu/zynqmp.rst b/Documentation/gpu/zynqmp.rst
> index f57bfa0ad6ec..1a6f9193de22 100644
> --- a/Documentation/gpu/zynqmp.rst
> +++ b/Documentation/gpu/zynqmp.rst
> @@ -144,6 +144,4 @@ Internals
>
>  .. kernel-doc:: drivers/gpu/drm/xlnx/zynqmp_dp.c
>
> -.. kernel-doc:: drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> -
>  .. kernel-doc:: drivers/gpu/drm/xlnx/zynqmp_kms.c
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.h
> b/drivers/gpu/drm/xlnx/zynqmp_dpsub.h
> index 49875529c2a4..d771b8b199e0 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.h
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.h
> @@ -60,6 +60,7 @@ struct zynqmp_dpsub_audio;
>   * @layers: Video and graphics layers
>   * @dp: The DisplayPort controller
>   * @dma_align: DMA alignment constraint (must be a power of 2)
> + * @audio: DP audio data
>   */
>  struct zynqmp_dpsub {
>       struct device *dev;
>
> ---
> base-commit: 74ef9527bd87ead62deabe749a6d867af748d448
> change-id: 20241220-xilinx-dp-audio-doc-fix-0651029616e7
>
> Best regards,
> --
> Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

This looks good to me. Apologies for missing this in my earlier review.

I tested this patch with
./scripts/kernel-doc -none drivers/gpu/drm/xlnx/zynqmp_dpsub.c
make htmldocs

Please feel free to add

Reviewed-by: Vishal Sagar <vishal.sagar@....com>

Regards
Vishal Sagar