linux-kernel - Re: [PATCH] mtd: spi-nor: extend description of size member of struct flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frmiwx07.fsf@bootlin.com>
Date: Fri, 20 Dec 2024 09:59:20 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Michael Walle" <mwalle@...nel.org>
Cc: "Tudor Ambarus" <tudor.ambarus@...aro.org>,  "Renjun Wang"
 <renjunw0@...mail.com>,  "Pratyush Yadav" <pratyush@...nel.org>,  "Richard
 Weinberger" <richard@....at>,  "Vignesh Raghavendra" <vigneshr@...com>,
  <linux-mtd@...ts.infradead.org>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: extend description of size member of
 struct flash_info

>> >> TBH I'd be perfectly fine (and prefer) a dedicated member, because
>> >> code clarity is IMO more important than memory footprint today.
>
> But that would have meant more code churn, because the default
> should be the new method. Thus we'd have to change all the old
> entries.

Oh yeah, I feel it would be a patchset on its own. I'm just mentioning
it if someone has the willingness some day. As for now, it is important
to properly document how we use the fields.