linux-kernel - Re: Suspend/resume failing due to SPD5118

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92a841f0-ab20-4243-9d95-54205790d616@roeck-us.net>
Date: Thu, 19 Dec 2024 17:20:54 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Lucas De Marchi <lucas.demarchi@...el.com>, linux-hwmon@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>
Subject: Re: Suspend/resume failing due to SPD5118

On 12/19/24 14:59, Lucas De Marchi wrote:
> Hi,
> 
> In our CI for xe and i915 drivers we are noticing some issues
> with suspend/resume with these error messages from spd5118:
> 
> <3> [120.648546] spd5118 3-0051: PM: dpm_run_callback(): spd5118_resume [spd5118] returns -110
> <3> [120.648598] spd5118 3-0051: PM: failed to resume async: error -110
> <3> [122.825989] spd5118 3-0053: PM: failed to resume async: error -110
> 
> Example:
> https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3885
> 
> (there are a few other issues in which this error shows up, but this is
> the the cleanest one that doesn't mix with other bugs)
> 
> thanks
> Lucas De Marchi
> 

The timeout is observed when the resume code tries to write data back to the
spd5118 chip. It originates from the i2c controller driver, not from the spd5118
driver. I have no idea why the i2c controller would time out in this situation.
Presumably it should have been brought out of suspend by the time devices connected
to it are re-enabled, but I don't see any associated message in the log.

I know that others have tested suspend/resume support with the driver and confirmed
that it works. It might help to enable debugging of the i2c controller driver if that
is possible. Other than that I have no idea what might cause this problem or how to
track it down.

Guenter