linux-kernel - Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra qcom,msm-id value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D6GG3YBXX62X.1JV54ZRWY7B5@fairphone.com>
Date: Fri, 20 Dec 2024 11:11:47 +0100
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Konrad Dybcio" <konrad.dybcio@....qualcomm.com>, "Bjorn Andersson"
 <andersson@...nel.org>, "Konrad Dybcio" <konradybcio@...nel.org>, "Rob
 Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "Luca Weiss" <luca@...aweiss.eu>
Cc: <~postmarketos/upstreaming@...ts.sr.ht>, <phone-devel@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra
 qcom,msm-id value

On Fri Dec 20, 2024 at 10:36 AM CET, Konrad Dybcio wrote:
> On 20.12.2024 9:55 AM, Luca Weiss wrote:
> > The ID 434 is for SM6350 while 459 is for SM7225. Fairphone 4 is only
> > SM7225, so drop the unused 434 entry.
> > 
> > Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairphone 4")
> > Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
> > ---
> > Completely dropping these values also appears to work when using
> > boot.img header version 2, but doing this change now would mean any
> > tooling in the wild for packaging up the boot.img using header v0 would
> > stop producing working without adjusting that mkbootimg invocation.
> > ---
>
> It would be nice if you could start shifting that tooling to bootimgv2
> slowly, and when it trickles down to appropriate places, switch it up
> upstream as well. Of course if that works for you.

In postmarketOS for sure it's simple to switch, I know Mobian also has
something for FP4, but apart from that I'm not sure if there's more
build scripts floating around somewhere.

>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>
> Konrad